Skip to content

refactor (edit path): could not edit shape paths when rotated#168

Merged
lallmon merged 8 commits into
mainfrom
fix/shape_edits_on_rotation
Jan 16, 2026
Merged

refactor (edit path): could not edit shape paths when rotated#168
lallmon merged 8 commits into
mainfrom
fix/shape_edits_on_rotation

Conversation

@lallmon

@lallmon lallmon commented Jan 16, 2026

Copy link
Copy Markdown
Owner

Pretty big change with a fundamental refactor.

@codecov

codecov Bot commented Jan 16, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 89.63415% with 17 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.03%. Comparing base (9864cd1) to head (7221dc7).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/lucent/canvas_model.py 88.57% 12 Missing ⚠️
src/lucent/canvas_items.py 66.66% 4 Missing ⚠️
src/lucent/item_schema.py 97.22% 1 Missing ⚠️

❌ Your patch status has failed because the patch coverage (89.63%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #168      +/-   ##
==========================================
- Coverage   92.17%   92.03%   -0.15%     
==========================================
  Files          23       23              
  Lines        3643     3691      +48     
==========================================
+ Hits         3358     3397      +39     
- Misses        285      294       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lallmon

lallmon commented Jan 16, 2026

Copy link
Copy Markdown
Owner Author

Codecov settings wrong, looking in to fix.

@lallmon lallmon merged commit 3899e53 into main Jan 16, 2026
3 of 4 checks passed
@lallmon lallmon deleted the fix/shape_edits_on_rotation branch January 16, 2026 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant