Skip to content

refactor (transforms): move out of the canvas model #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lallmon merged 3 commits into from
Jan 17, 2026
Merged

refactor (transforms): move out of the canvas model #171

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c20e56f
refactor (transforms): move to one place
lallmon Jan 17, 2026
240e25f
chore (transform): move transform math out of the model
lallmon Jan 17, 2026
5ce74bf
chore (refactor): unused tests
lallmon Jan 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions components/Canvas.qml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,14 +91,14 @@ Item {
onOverlayRotateRequested: function (angle) {
var idx = Lucent.SelectionManager.selectedItemIndex;
if (idx >= 0 && canvasModel) {
canvasModel.updateTransformProperty(idx, "rotate", angle);
canvasModel.rotateItem(idx, angle);
}
}

onOverlayScaleResizeRequested: function (scaleX, scaleY, anchorX, anchorY) {
var idx = Lucent.SelectionManager.selectedItemIndex;
if (idx >= 0 && canvasModel) {
canvasModel.applyScaleResize(idx, scaleX, scaleY, anchorX, anchorY);
canvasModel.scaleItem(idx, scaleX, scaleY, anchorX, anchorY);
}
}

Expand Down Expand Up @@ -371,7 +371,7 @@ Item {
var indices = Lucent.SelectionManager.selectedIndices || [];
if (indices.length === 0)
return;
canvasModel.moveItems(indices, canvasDx, canvasDy);
canvasModel.translateItems(indices, canvasDx, canvasDy);
}

function deleteSelectedItem() {
Expand Down
12 changes: 5 additions & 7 deletions components/PathEditController.qml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ QtObject {
}
}

canvasModel.updateGeometryWithOriginCompensation(idx, {
canvasModel.updateGeometryLocked(idx, {
points: newPoints,
closed: item.geometry.closed
});
Expand Down Expand Up @@ -175,7 +175,7 @@ QtObject {
}
}

canvasModel.updateGeometryWithOriginCompensation(idx, {
canvasModel.updateGeometryLocked(idx, {
points: newPoints,
closed: item.geometry.closed
});
Expand Down Expand Up @@ -205,11 +205,9 @@ QtObject {
canvasModel.removeItem(idx);
Lucent.SelectionManager.exitEditMode();
} else {
canvasModel.updateItem(idx, {
geometry: {
points: newPoints,
closed: item.geometry.closed && newPoints.length >= 3
}
canvasModel.updateGeometryLocked(idx, {
points: newPoints,
closed: item.geometry.closed && newPoints.length >= 3
});
Lucent.SelectionManager.clearPointSelection();
}
Expand Down
4 changes: 2 additions & 2 deletions components/panels/TransformPanel.qml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -462,7 +462,7 @@ Item {

// Model normalizes to 0-360° automatically
var val = parseInt(text) || 0;
canvasModel.updateTransformProperty(root.selectedIndex, "rotate", val);
canvasModel.rotateItem(root.selectedIndex, val);
appController.focusCanvas();

isCommitting = false;
Expand All @@ -487,7 +487,7 @@ Item {
canvasModel.endTransaction();
}

onMoved: canvasModel.updateTransformProperty(root.selectedIndex, "rotate", value)
onMoved: canvasModel.rotateItem(root.selectedIndex, value)

handle: Rectangle {
x: rotationSlider.leftPadding + rotationSlider.visualPosition * (rotationSlider.availableWidth - width)
Expand Down
Loading