chore(repo): add clippy to enforce warnings before they're pushed#181
Merged
chore(repo): add clippy to enforce warnings before they're pushed#181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a
clippypre-commit hook for Rust changes so commits fail if clippy emits any warnings.Related Issues
N/A
Changes
clippyhook to.pre-commit-config.yamlthat runsrustup run nightly cargo clippy --workspace --all-targets -- -D warnings.Type of Change
Affected Crates
lambda-rslambda-rs-platformlambda-rs-argslambda-rs-loggingChecklist
cargo +nightly fmt --all)cargo clippy --workspace --all-targets -- -D warnings)cargo test --workspace)Testing
Commands run:
Manual verification steps (if applicable):
Screenshots/Recordings
N/A
Platform Testing
Additional Notes
rustup run nightly ..., matching the existingfmthook, so contributors will need thenightlytoolchain available for pre-commit to run clippy.