Skip to content

Fix Php 8.5 deprecation#48

Merged
froschdesign merged 4 commits into
laminas:2.20.xfrom
sandesh-as:php_85_support
Mar 31, 2026
Merged

Fix Php 8.5 deprecation#48
froschdesign merged 4 commits into
laminas:2.20.xfrom
sandesh-as:php_85_support

Conversation

@sandesh-as
Copy link
Copy Markdown
Contributor

Q A
Documentation yes/no
Bugfix yes/no
BC Break yes/no
New Feature yes/no
RFC yes/no
QA yes/no

Description

Signed-off-by: sandesh.as <cod48668@adobe.com>
Signed-off-by: sandesh.as <cod48668@adobe.com>
@sandesh-as sandesh-as marked this pull request as draft December 1, 2025 11:22
Signed-off-by: sandesh.as <cod48668@adobe.com>
@sandesh-as sandesh-as marked this pull request as ready for review December 2, 2025 12:52
@froschdesign froschdesign added the Bug Something isn't working label Dec 10, 2025
@froschdesign froschdesign added this to the 2.19.1 milestone Dec 10, 2025
@sandesh-as
Copy link
Copy Markdown
Contributor Author

sandesh-as commented Jan 2, 2026

@froschdesign During our investigation, we identified circular dependencies among several Laminas packages. To address this, we have updated the dependency constraints and allowed both 2.x and 3.x versions for the affected packages.

We also wanted to raise a concern regarding laminas/laminas-text (see: https://github.com/laminas/laminas-captcha/pull/48/files#diff-d2ab9925cad7eac58e0ff4cc0d251a937ecf49e4b6bf57f8b95aab76648a9d34L33
). Since this package is abandoned and not compatible with PHP 8.5, it may introduce ongoing compatibility and maintenance challenges. Are we considering removing or replacing this dependency? We would appreciate your thoughts on how you’d like to proceed.

We also observed a similar situation with the 3.0.x-dev branch of laminas/laminas-http. In this branch, the abandoned laminas/laminas-loader dependency has already been removed. However, adoption of the 3.0.x version is currently blocked by laminas/laminas-recaptcha, which still requires the 2.x version of laminas-http, We would appreciate your thoughts on how you’d like to proceed.

@froschdesign
Copy link
Copy Markdown
Member

Are we considering removing or replacing this dependency?

Removing is the best option here.

We also observed a similar situation with the 3.0.x-dev branch of laminas/laminas-http.

There is no new version needed because the problem is already fixed.
Further information on this topic:

@froschdesign
Copy link
Copy Markdown
Member

@sandesh-as

We also wanted to raise a concern regarding laminas/laminas-text

See: https://github.com/laminas/laminas-text/releases/tag/2.13.0

@glo71317
Copy link
Copy Markdown
Contributor

glo71317 commented Feb 3, 2026

@froschdesign Do we have an estimated timeline for when this change will be available for use?

@sandesh-as
Copy link
Copy Markdown
Contributor Author

Hi @froschdesign,

Just following up on this.

Support for PHP 8.5 was introduced in Pr and while integrating it, we encountered a few deprecated function usages. To address those, we’ve opened this PR with the necessary fixes.

Could you please take a look when you have a moment? A review and merge would help us move forward with PHP 8.5 compatibility.

@froschdesign froschdesign requested a review from samsonasik March 30, 2026 08:52
@samsonasik
Copy link
Copy Markdown
Member

@froschdesign if this on 2.19.1 milestone, is branch target need to be changed to 2.9.x?

@froschdesign
Copy link
Copy Markdown
Member

@samsonasik
That would not be helpful: 2.19.x...2.20.x

@froschdesign froschdesign modified the milestones: 2.19.1, 2.20.0 Mar 30, 2026
@froschdesign froschdesign merged commit 0dfdef3 into laminas:2.20.x Mar 31, 2026
13 checks passed
@froschdesign
Copy link
Copy Markdown
Member

@sandesh-as
Thank you for your time and this contribution! 👍

@glo71317
Copy link
Copy Markdown
Contributor

@froschdesign Thanks for merge this PR :) Can we expect stable version for this?

@froschdesign
Copy link
Copy Markdown
Member

@glo71317
There is another open pull request on the milestone which needs some fixes. After this we can close the milestone and a release will be created.

@glo71317
Copy link
Copy Markdown
Contributor

Sounds good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants