Skip to content

Use StructArmed on QA - #178

Merged
gsteel merged 1 commit into
laminas:5.1.xfrom
samsonasik:use-structarmed-on-qa
Oct 2, 2026
Merged

gsteel merged 1 commit into
laminas:5.1.xfrom
samsonasik:use-structarmed-on-qa

Conversation

@samsonasik

Copy link
Copy Markdown
Member
Q A
QA yes

Description

This PR to make use of StructArmed.

This PR start apply StructArmed with initialize using PSR4 and CODEQUALITY preset, and MustBeFinalRule to make test classes final, and already help fix 22 violations.

Applied with single command:

vendor/bin/structarmed analyze --fix

I also enable ruleset above so it show more ability of layering setup to define which layers each layer is allowed to depend on.

Signed-off-by: Abdul Malik Ikhsan <samsonasik@gmail.com>
@samsonasik

Copy link
Copy Markdown
Member Author

Ready for review 👍

@gsteel gsteel self-assigned this Oct 2, 2026
@gsteel gsteel added the QA Quality assurance tasks such as static analysis improvements label Oct 2, 2026
@gsteel gsteel added this to the 5.1.0 milestone Oct 2, 2026
@gsteel
gsteel merged commit 409b4ba into laminas:5.1.x Oct 2, 2026
18 checks passed
@samsonasik
samsonasik deleted the use-structarmed-on-qa branch October 2, 2026 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

QA Quality assurance tasks such as static analysis improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants