Skip to content

Replace PHP_Codesniffer and Psalm with Mago - #476

Open
gsteel wants to merge 5 commits into
laminas:3.18.xfrom
gsteel:mago
Open

Replace PHP_Codesniffer and Psalm with Mago#476
gsteel wants to merge 5 commits into
laminas:3.18.xfrom
gsteel:mago

Conversation

@gsteel

@gsteel gsteel commented Jul 6, 2026

Copy link
Copy Markdown
Member

The baselines here are pretty large:

  • SA: 428 issues: 142 errors, 256 warnings, 30 help messages
  • Lint: 172 issues: 49 errors, 64 warnings, 59 help messages

This is a relatively low-effort PR to illustrate what's involved to make the switch.

Bear in mind the the psalm baseline was nearly empty here.

For comparison, Mago's lint, analyse and format runs each take a second, compared to Psalm at 35 - 40 seconds on this codebase.

@gsteel gsteel added the RFC label Jul 6, 2026
gsteel added 4 commits July 6, 2026 10:22
Signed-off-by: George Steel <george@net-glue.co.uk>
Signed-off-by: George Steel <george@net-glue.co.uk>
Signed-off-by: George Steel <george@net-glue.co.uk>
…ving now redundant configuration files

Signed-off-by: George Steel <george@net-glue.co.uk>
Signed-off-by: George Steel <george@net-glue.co.uk>
@froschdesign

Copy link
Copy Markdown
Member

@gsteel
Shall we discuss this at the next meeting? This pull request would be a great example of that.

@gsteel

gsteel commented Jul 6, 2026

Copy link
Copy Markdown
Member Author

@froschdesign
Just writing a patch for tonights meeting now. That's what this is for 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants