ci: add Makefile and GitHub Actions workflow for PR checks#25
Open
wombatu-kun wants to merge 3 commits into
Open
ci: add Makefile and GitHub Actions workflow for PR checks#25wombatu-kun wants to merge 3 commits into
wombatu-kun wants to merge 3 commits into
Conversation
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the canonical local build entry point (
Makefile) and the main CIworkflow (
.github/workflows/flink.yml).After merge, every PR against
mainis gated by two jobs:lint—mvn spotless:check checkstyle:checkbuild-and-test—mvn install -DskipTestsfollowed bymvn testBoth run on Ubuntu 24.04 with Temurin 8 (matching
maven.compiler.target=1.8and Flink 1.16.1 native Java) and use theactions/setup-javaMaven cache. Concurrency is configured to cancelin-progress runs when new commits land on a PR.
Stacking
This PR is stacked on top of
build/code-style-setup(Spotless,Checkstyle, Enforcer plugin configuration) and
chore/apply-initial-formatting(initial
spotless:applypass over the existing sources). The PR diffcurrently includes their commits as well; once both upstream PRs merge
and this branch is rebased onto
main, only the two new files remain.Forward compatibility
The Makefile exposes
install-all,test-all,build-allaliasesthat currently forward to their single-module counterparts. These are
reserved for a future multi-module iteration pattern over
FLINK_VERSION, so.github/workflows/flink.ymlwill not need to berewritten when that lands.