Skip to content

fix: respect v4 appserver as default ssh service in mixed-api apps #461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
reynoldsalec merged 1 commit into from
Apr 28, 2026
Merged

fix: respect v4 appserver as default ssh service in mixed-api apps #461

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions lib/app.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -351,11 +351,15 @@ module.exports = class App {

// reset the default service to the primary v4 service if we only have v4 services
if (this._serviceApi === 4) this._defaultService = this.v4.primaryService.name;
// reset the default service to the first v3 service if there is no appserver
else if (this.serviceGroups['3'].length > 0 && !_.find(this.serviceGroups['3'], {service: 'appserver'})) {
// reset the default service to the first v3 service if there is no appserver in v3 or v4
else if (this.serviceGroups['3'].length > 0
&& !_.find(this.serviceGroups['3'], {service: 'appserver'})
&& !_.find(this.serviceGroups['4'], {service: 'appserver'})) {
this._defaultService = this.serviceGroups['3'][0].service;
// reset the default service to the first compose service if there is no appserver
} else if (this.serviceGroups.compose.length > 0 && !_.find(this.serviceGroups.compose, {service: 'appserver'})) {
// reset the default service to the first compose service if there is no appserver in compose or v4
} else if (this.serviceGroups.compose.length > 0
&& !_.find(this.serviceGroups.compose, {service: 'appserver'})
&& !_.find(this.serviceGroups['4'], {service: 'appserver'})) {
this._defaultService = this.serviceGroups.compose[0].service;
}

Expand Down
Loading