Skip to content

refactor(docs): slim contributors config, rely on theme defaults #463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
AaronFeledy wants to merge 2 commits into from
Closed

refactor(docs): slim contributors config, rely on theme defaults #463

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9b2fc07
refactor(docs): slim contributors config, rely on theme defaults
AaronFeledy Apr 24, 2026
e0ec822
refactor(docs): drop Mike's local desc override, fully inherit from t…
AaronFeledy Apr 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 1 addition & 37 deletions docs/.vitepress/config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,43 +86,7 @@ export default defineConfig({
patterns: ['help/**/*.md', 'troubleshooting/**/*.md'],
},
},
contributors: {
merge: 'name',
debotify: true,
include: [
{
name: 'Mike Pirog',
email: 'mike@lando.dev',
title: 'Co-founder',
org: 'lando.dev',
orgLink: 'https://lando.dev',
desc: 'SLAVE4U',
links: [
Copy link
Copy Markdown

@cursor cursor Bot Apr 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Theme dependency not bumped to required version

High Severity

The contributors block now relies on landov3 defaults from @lando/vitepress-theme-default-plus ≥ v1.2.0 (as stated in the PR description), but package.json still specifies "^1.1.5" and the lockfile pins 1.1.5. A fresh npm install resolves to v1.1.5 which lacks the default contributor entries for Mike Pirog, Alec Reynolds, and Aaron Feledy — breaking the /team page rendering. The dependency version needs to be bumped alongside this config change.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 9b2fc07. Configure here.

{icon: 'github', link: 'https://github.com/pirog'},
{icon: 'x', link: 'https://x.com/pirogcommamike'},
],
sponsor: 'https://lando.dev/sponsor',
maintainer: true,
mergeOnly: true,
},
{
avatar: 'https://avatars.githubusercontent.com/u/1153738',
name: 'Alec Reynolds',
email: 'alec+git@thinktandem.io',
title: 'Co-founder',
org: 'lando.dev',
orgLink: 'https://lando.dev',
desc: 'A chill dude',
links: [
{icon: 'github', link: 'https://github.com/reynoldsalec'},
{icon: 'x', link: 'https://x.com/reynoldsalec'},
],
sponsor: 'https://lando.dev/sponsor',
maintainer: true,
mergeOnly: true,
},
],
},

Copy link
Copy Markdown

@cursor cursor Bot Apr 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Contributors override block entirely removed instead of slimmed

High Severity

The contributors block was completely removed rather than replaced with the slimmed-down version described in the PR. The PR explicitly states the config should contain a contributors object with an include array carrying Mike Pirog's {email: 'mike@lando.dev', desc: 'SLAVE4U', mergeOnly: true} override, but the committed file has no contributors key at all. Without this override, Mike's custom desc field won't be applied on the /team page.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit e0ec822. Configure here.

sidebar: {
'/cli': cliBar(),
'/config': configBar(),
Expand Down
Loading