Skip to content

refactor: remove over precise svg decimals#1822

Open
mfortman11 wants to merge 5 commits into
mainfrom
perf-svg-precision
Open

refactor: remove over precise svg decimals#1822
mfortman11 wants to merge 5 commits into
mainfrom
perf-svg-precision

Conversation

@mfortman11

@mfortman11 mfortman11 commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Over-precise SVG d/points decimals = wasted bytes. Pure mechanical fix, all in components/icons/*.

Summary by CodeRabbit

  • Style
    • Optimized application icons by refining SVG path data and simplifying numeric coordinate formatting. All icons—including brand logos, provider integrations, and interface elements—maintain their original visual appearance and performance. These optimizations improve rendering efficiency and reduce asset complexity without introducing any visible changes to the user experience.

@coderabbitai

coderabbitai Bot commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 52d04bba-8da7-4f95-bf51-dd1037fc5afb

📥 Commits

Reviewing files that changed from the base of the PR and between 8530ab0 and d7f29b4.

📒 Files selected for processing (13)
  • frontend/app/settings/_components/langflow-icon.tsx
  • frontend/components/icons/anthropic-logo.tsx
  • frontend/components/icons/aws-logo.tsx
  • frontend/components/icons/google-drive-logo.tsx
  • frontend/components/icons/google-logo.tsx
  • frontend/components/icons/ibm-logo.tsx
  • frontend/components/icons/incident-reporter-icon.tsx
  • frontend/components/icons/ollama-logo.tsx
  • frontend/components/icons/one-drive-logo.tsx
  • frontend/components/icons/openai-logo.tsx
  • frontend/components/icons/openrag-logo.tsx
  • frontend/components/icons/share-point-logo.tsx
  • frontend/enhancements/connectors/ibm-cos/icon.tsx

Walkthrough

Thirteen SVG icon components receive geometry and styling updates. Path d attributes are replaced with new coordinate data across anthropic, AWS, Google Drive, Google, IBM, Langflow, Ollama, OpenAI, and OpenRAG logos. One Drive and SharePoint logos additionally update gradient transforms and stop values. IBM COS icon receives path and gradient stop adjustments.

Changes

Icon SVG geometry and styling updates

Layer / File(s) Summary
Simple path geometry updates
frontend/components/icons/anthropic-logo.tsx, frontend/app/settings/_components/langflow-icon.tsx, frontend/components/icons/incident-reporter-icon.tsx, frontend/components/icons/openrag-logo.tsx, frontend/components/icons/aws-logo.tsx, frontend/components/icons/google-drive-logo.tsx, frontend/components/icons/google-logo.tsx, frontend/components/icons/ibm-logo.tsx, frontend/components/icons/ollama-logo.tsx, frontend/components/icons/openai-logo.tsx
Eleven icon files updated with new SVG path d coordinate data and minor transform/offset adjustments (e.g., Ollama's clipPath translate precision). Fill colors and overall component structure remain unchanged.
Complex logo updates with paths, gradients, and transforms
frontend/components/icons/one-drive-logo.tsx, frontend/components/icons/share-point-logo.tsx, frontend/enhancements/connectors/ibm-cos/icon.tsx
One Drive and SharePoint logos receive updated path geometries alongside multiple radial and linear gradient gradientTransform parameters, stop offset/opacity values, and clipPath rectangle dimension/transform changes. IBM COS icon updates mask SVG paths and a gradient stop offset value.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

  • langflow-ai/openrag#1647: Both PRs touch frontend/components/icons/incident-reporter-icon.tsx; the retrieved PR introduces the component while this PR updates its SVG path data.
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 11.11% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'refactor: remove over precise svg decimals' directly and clearly describes the main change: reducing unnecessary decimal precision in SVG files throughout the codebase.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch perf-svg-precision

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added frontend 🟨 Issues related to the UI/UX community refactor and removed refactor labels Jun 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community frontend 🟨 Issues related to the UI/UX refactor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant