Fix: Stale api keys no longer display on the page once revoked#1878
Fix: Stale api keys no longer display on the page once revoked#1878Vchen7629 wants to merge 2 commits into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
Walkthrough
ChangesRevoked key filter in list_keys
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Suggested labels
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
NishadA05
left a comment
There was a problem hiding this comment.
I checked out this PR locally and tested the API key flow.
Manual test:
Started OpenRAG from this PR branch.
Created a new API key.
Confirmed the new key appeared in the API keys list.
Revoked the key.
Refreshed/reopened the API keys page.
Confirmed the revoked key no longer appeared.
I also reviewed the diff, and filtering revoked API keys out at the service query level makes sense for this issue since the frontend should only receive active keys to display.
Looks good.
|
Superseeded by #1925 |
Summary
Fixes #1877, Updates the opensearch query to only fetch non revoked (revoked = False) api keys so the frontend recieves only non-revoked keys to display.
Demo (Before)
screen-capture.6.webm
Demo (After)
screen-capture.7.webm
Changes
api_key_service.pylist_keys opensearch query to also filter for keys that have revoked set to falseSummary by CodeRabbit