fix: improve error handling and status updates for document processing and add OCR requirement check for image files#1881
Open
ricofurtado wants to merge 2 commits into
Conversation
…g and add OCR requirement check for image files
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
5b36bb9 to
795337d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supported File Types by Ingestion Path
There are currently two different supported file type lists depending on how content is ingested into OpenRAG.
Direct Upload (Frontend File Picker)
Defined in
knowledge-dropdown.tsx(lines 60–76)..txt,.md,.pdf,.docx,.html,.htm,.adoc,.asciidoc,.asc.csv,.xlsx.pptxConnector Ingestion (Backend Validator)
Defined in
processors.py(lines 645–668).Includes all file types supported by Direct Upload, plus additional Office formats, XHTML, and image formats.
.txt,.md,.pdf,.docx,.html,.htm,.adoc,.asciidoc,.asc.dotx,.dotm,.docm.csv,.xlsx,.xls.pptx,.potx,.ppsx,.pptm,.potm,.ppsm.xhtml.jpg,.jpeg,.png,.tiff,.bmp,.webpRoot Cause of the Reported Defect
The image formats (
.jpg,.jpeg,.png,.tiff,.bmp,.webp) are the source of the reported issue.What Happens
Existing Frontend Limitation
The frontend intentionally excludes several file types that are accepted by connector ingestion.
A TODO comment in
knowledge-dropdown.tsx(line 57) states:This indicates that support for images and additional document types was intentionally withheld from the file picker until end-to-end ingestion behavior was fully validated.
Gap Between Frontend and Connector Validation
This inconsistency allows image files to be ingested through connectors while bypassing the frontend restrictions, creating the gap that exposed the bug.
Summary by CodeRabbit
Bug Fixes