fix: fixed issue #1587#1885
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
WalkthroughAdds a fallback branch in ChangesLLM Sync Fallback and Local Deployment
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related issues
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
NishadA05
left a comment
There was a problem hiding this comment.
I checked out this PR locally and reviewed the diff. The change is narrow and limited to src/api/settings/langflow_sync.py. It updates the fallback path in _update_langflow_model_values() so that when no explicit model/provider overrides are passed, the configured agent LLM provider/model is forced back into the Langflow chat flow with force_llm_update=True.
That seems to address the main issue where the fallback path refreshed embedding providers but did not force an LLM update after a flow reset/reapply.
One note: the issue prompt mentioned iterating all configured LLM providers similar to the embedding provider loop. This PR instead updates only the active/default config.agent LLM provider/model. That seems sufficient if the goal is to restore the active chat model after reset, but it is narrower than the originally suggested approach.
Description
Fixes issue #1587, where resetting a flow causes the LLM selection to revert to a stale or default model.
In
src/api/settings/langflow_sync.py, the fallback branch of_update_langflow_model_values(called duringreapply_all_settings()) was only iterating and refreshing configured embedding providers. It completely bypassed updating the LLM providers, meaning the chat flow never received aforce_llm_update=Truesignal.Changes
src/api/settings/langflow_sync.pyinsidereapply_all_settings().Summary by CodeRabbit
8000for easier local access.