Skip to content

fix: add warning logs for 10k aggregation limit in sync operations #1912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yogichipalkatti wants to merge 1 commit into
base: release-0.5.1
Choose a base branch
from
Open

fix: add warning logs for 10k aggregation limit in sync operations #1912

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions src/api/connectors.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,12 @@ async def get_synced_file_ids_for_connector(
result.get("aggregations", {}).get("unique_connector_file_ids", {}).get("buckets", [])
)
connector_file_ids = [b["key"] for b in connector_file_id_buckets if b["key"]]

if len(connector_file_id_buckets) == 10000:
logger.warning(
"Connector file ID aggregation hit 10k limit - results may be truncated",
connector_type=connector_type,
returned_count=len(connector_file_ids),
)
if connector_file_ids:
file_ids = connector_file_ids
id_field = "connector_file_id"
Expand All @@ -78,13 +83,18 @@ async def get_synced_file_ids_for_connector(
result.get("aggregations", {}).get("unique_document_ids", {}).get("buckets", [])
)
file_ids = [b["key"] for b in doc_id_buckets if b["key"]]
if len(doc_id_buckets) == 10000:
logger.warning("Document ID aggregation hit 10k limit - results may be truncated",
connector_type=connector_type, returned_count=len(file_ids),)
id_field = "document_id"

filename_buckets = (
result.get("aggregations", {}).get("unique_filenames", {}).get("buckets", [])
)
filenames = [b["key"] for b in filename_buckets if b["key"]]

if len(filename_buckets) == 10000:
logger.warning("Filename aggregation hit 10k limit - results may be truncated",
connector_type=connector_type, returned_count=len(filenames),)
logger.debug(
"Found synced files for connector",
connector_type=connector_type,
Expand Down Expand Up @@ -133,6 +143,9 @@ async def get_synced_id_to_filename_map(

result = await opensearch_client.search(index=get_index_name(), body=query_body)
buckets = result.get("aggregations", {}).get("by_document_id", {}).get("buckets", [])
if len(buckets) == 10000:
logger.warning("Document ID to filename mapping hit 10k limit - results may be truncated",
connector_type=connector_type, returned_count=len(buckets),)

mapping: dict[str, str] = {}
for bucket in buckets:
Expand Down
Loading