fix: Ingestion of buckets not working right after connection is tested - CPD #75506

[ricofurtado]

This pull request updates the S3 and IBM Cloud Object Storage (IBMCOS) settings and upload flows to improve clarity for users and to support initializing the bucket selection with default values. The main changes include updating user-facing labels and messages for better clarity, and adding logic to pre-select default buckets when presenting the bucket selection UI.

User interface and messaging improvements:

• Updated labels and descriptions in both S3 and IBMCOS settings forms to use clearer wording: "Restrict to Specific Buckets" and "(leave all unchecked to include all)" instead of the previous "Select Buckets to Ingest" messaging. [1] [2]
• Changed success toast messages in both S3 and IBMCOS settings dialogs to use "Filtered to: ..." and "All accessible buckets are included." for improved clarity. [1] [2]

Bucket selection initialization enhancements:

• Added support for passing an initialSelectedBuckets prop to the BucketView component, and logic to pre-select these buckets if they are valid for the current connector. (frontend/app/upload/[provider]/page.tsxR54, frontend/app/upload/[provider]/page.tsxR66-R94)
• Integrated useS3DefaultsQuery and useIBMCOSDefaultsQuery hooks to fetch default bucket selections for S3 and IBMCOS, respectively, and passed these defaults to the bucket selection UI. (frontend/app/upload/[provider]/page.tsxL12-R20, frontend/app/upload/[provider]/page.tsxR342, frontend/app/upload/[provider]/page.tsxR354, frontend/app/upload/[provider]/page.tsxR382, frontend/app/upload/[provider]/page.tsxR395)

Summary by CodeRabbit

• New Features

  • Added support for pre-selecting buckets when uploading to Amazon S3 and IBM Cloud Object Storage based on connector configuration.

• Improvements

  • Updated bucket selector UI labels and confirmation messages for improved clarity about bucket filtering and inclusion options.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: efdd4fd4-f60d-41a8-be03-8186de7a48fd

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 42.86% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check	❓ Inconclusive	The PR title focuses on fixing bucket ingestion workflow after connection testing, but the actual changes are primarily UI text updates to bucket selector labels and success messages, plus a feature to support pre-selecting buckets via connector defaults.	Clarify whether the title accurately reflects the primary changes (UI text updates and bucket pre-selection feature) or if the actual fixes to ingestion logic should be more prominently featured in the changeset.

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix-cpd-ingestion-of-buckets-not-working-right-after-connection-is-tested-75506

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}