Add ability to provide module with cert ARN & Other Fixes#60
Draft
jamesstonehill wants to merge 11 commits into
Draft
Add ability to provide module with cert ARN & Other Fixes#60jamesstonehill wants to merge 11 commits into
jamesstonehill wants to merge 11 commits into
Conversation
68849e4 to
8bdf629
Compare
21c8309 to
b23344f
Compare
1931936 to
eda5220
Compare
eda5220 to
f9c5801
Compare
3ad7b69 to
41ddf53
Compare
41ddf53 to
0d99679
Compare
7e841db to
32913d5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When attempting to deploy langfuse, we encountered a few issues. This PR fixes some of these issues. The changes made are:
*.example.comyou can use this certificate for your langfuse deployment onlangfuse.example.com.nameproperty. This means that if you wanted to have two langfuse deployments in the same AWS account (e.g. with a mult-regional setup), you'd end up getting IAM role name clashes. This PR changes it so that the IAM resources now use name_prefix to avoid name clashes. [THIS IS A BREAKING CHANGE] because it requires some resources to be recreated so should only be released as part of a major release.