Skip to content

Add ability to provide module with cert ARN & Other Fixes#60

Draft
jamesstonehill wants to merge 11 commits into
langfuse:mainfrom
NLPatent:add-certificate-as-input
Draft

Add ability to provide module with cert ARN & Other Fixes#60
jamesstonehill wants to merge 11 commits into
langfuse:mainfrom
NLPatent:add-certificate-as-input

Conversation

@jamesstonehill
Copy link
Copy Markdown

@jamesstonehill jamesstonehill commented May 8, 2026

When attempting to deploy langfuse, we encountered a few issues. This PR fixes some of these issues. The changes made are:

  • Ability to pass in pre-created certificate: It's nice to be able to pass in a pre-existing certificate so that if you have a wildcard certificate like *.example.com you can use this certificate for your langfuse deployment on langfuse.example.com.
  • Ability to skip dns setup. The current DNS setup assumes AWS is your registrar. We use Cloudflare so the current setup wouldn't work for us so this PR adds the ability to skip the DNS setup and exposes the k8s lb needed to setup DNS externally.
  • Unique IAM names. Currently the IAM resources uses just the name property. This means that if you wanted to have two langfuse deployments in the same AWS account (e.g. with a mult-regional setup), you'd end up getting IAM role name clashes. This PR changes it so that the IAM resources now use name_prefix to avoid name clashes. [THIS IS A BREAKING CHANGE] because it requires some resources to be recreated so should only be released as part of a major release.
  • Adds kubernetes_annotations needed for CoreDNS.

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented May 8, 2026

CLA assistant check
All committers have signed the CLA.

@jamesstonehill jamesstonehill changed the title Add ability to provide module with cert ARN Add ability to provide module with cert ARN & Other Fixes May 8, 2026
@jamesstonehill jamesstonehill force-pushed the add-certificate-as-input branch 5 times, most recently from 68849e4 to 8bdf629 Compare May 8, 2026 20:14
@jamesstonehill jamesstonehill force-pushed the add-certificate-as-input branch from 21c8309 to b23344f Compare May 9, 2026 15:48
@jamesstonehill jamesstonehill force-pushed the add-certificate-as-input branch 3 times, most recently from 1931936 to eda5220 Compare May 11, 2026 10:17
@jamesstonehill jamesstonehill marked this pull request as draft May 11, 2026 10:22
@jamesstonehill jamesstonehill force-pushed the add-certificate-as-input branch from eda5220 to f9c5801 Compare May 11, 2026 10:42
@jamesstonehill jamesstonehill force-pushed the add-certificate-as-input branch 3 times, most recently from 3ad7b69 to 41ddf53 Compare May 11, 2026 17:06
@jamesstonehill jamesstonehill force-pushed the add-certificate-as-input branch from 41ddf53 to 0d99679 Compare May 12, 2026 14:24
@jamesstonehill jamesstonehill force-pushed the add-certificate-as-input branch from 7e841db to 32913d5 Compare May 19, 2026 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants