feat(terraform): add code-based eval executors (LFE-9943)#61
Conversation
Refs LFE-9943.
| } | ||
| } | ||
|
|
||
| module "code_based_eval_executor_vpc" { |
There was a problem hiding this comment.
We could also kick out the VPC to make the setup easier - what do you think @Steffen911 ?
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fbb12ba98a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| data "archive_file" "code_based_eval_executor" { | ||
| for_each = var.enable_code_based_eval_executors ? local.code_based_eval_executor_lambda_configs : {} | ||
|
|
||
| type = "zip" | ||
| output_path = "${path.module}/.terraform/code_based_eval_executor_${each.key}.zip" |
There was a problem hiding this comment.
Avoid plan-time archive generation for Lambda packages
Using data "archive_file" here makes packaging happen during terraform plan, but aws_lambda_function.filename is consumed during apply. In multi-phase workflows (separate plan/apply jobs or runners), that zip file often is not present at apply time, so Lambda creation fails with a missing artifact. The archive provider docs explicitly call out this behavior and recommend the archive_file resource when artifacts cannot be persisted between phases.
Useful? React with 👍 / 👎.
Summary
Linear
Major Decisions
enable_code_based_eval_executorsas the only code-based eval enable flag so community users do not have to coordinate separate infra and worker settings.Review Focus
variables.tf,outputs.tf, and README docs.