Skip to content

chore: inject more db.session#38045

Open
asukaminato0721 wants to merge 10 commits into
langgenius:mainfrom
asukaminato0721:db.session-more
Open

chore: inject more db.session#38045
asukaminato0721 wants to merge 10 commits into
langgenius:mainfrom
asukaminato0721:db.session-more

Conversation

@asukaminato0721

@asukaminato0721 asukaminato0721 commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Important

  1. Make sure you have read our contribution guidelines
  2. Ensure there is an associated issue and you have been assigned to it
  3. Use the correct syntax to link this PR: Fixes #<issue number>.

Summary

#37403

Screenshots

Before After
... ...

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran make lint && make type-check (backend) and cd web && pnpm exec vp staged (frontend) to appease the lint gods

[autofix.ci] apply automated fixes

.

type

[autofix.ci] apply automated fixes
@dosubot dosubot Bot added size:XXL This PR changes 1000+ lines, ignoring generated files. refactor labels Jun 26, 2026
@asukaminato0721 asukaminato0721 changed the title chore: inject more chore: inject more db.session Jun 26, 2026
@github-actions

github-actions Bot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Pyrefly Diff

base → PR
--- /tmp/pyrefly_base.txt	2026-06-28 14:49:54.542947972 +0000
+++ /tmp/pyrefly_pr.txt	2026-06-28 14:49:44.426949999 +0000
@@ -1085,7 +1085,7 @@
 ERROR Argument `Literal['normal']` is not assignable to parameter `status` with type `SQLCoreOperations[TenantStatus] | TenantStatus` in function `models.account.Tenant.__init__` [bad-argument-type]
   --> tests/test_containers_integration_tests/services/test_dataset_service.py:40:58
 ERROR Argument `Literal['invalid_action']` is not assignable to parameter `action` with type `Literal['archive', 'disable', 'enable', 'un_archive']` in function `services.dataset_service.DocumentService.batch_update_document_status` [bad-argument-type]
-   --> tests/test_containers_integration_tests/services/test_dataset_service_batch_update_document_status.py:712:64
+   --> tests/test_containers_integration_tests/services/test_dataset_service_batch_update_document_status.py:738:24
 ERROR Argument `Literal['owner']` is not assignable to parameter `role` with type `SQLCoreOperations[TenantAccountRole] | TenantAccountRole` in function `models.account.TenantAccountJoin.__init__` [bad-argument-type]
   --> tests/test_containers_integration_tests/services/test_dataset_service_create_dataset.py:36:18
 ERROR Argument `Literal['active']` is not assignable to parameter `status` with type `AccountStatus | SQLCoreOperations[AccountStatus]` in function `models.account.Account.__init__` [bad-argument-type]
@@ -6306,45 +6306,45 @@
 ERROR Returned type `dict[str, Blueprint]` is not assignable to declared return type `Iterator[dict[str, Blueprint]]` [bad-return]
   --> tests/unit_tests/extensions/test_ext_blueprints_openapi.py:79:12
 ERROR `None` is not subscriptable [unsupported-operation]
-   --> tests/unit_tests/extensions/test_ext_request_logging.py:153:16
-ERROR Cannot index into `Mapping[str, object]` [bad-index]
-   --> tests/unit_tests/extensions/test_ext_request_logging.py:153:28
-ERROR `None` is not subscriptable [unsupported-operation]
    --> tests/unit_tests/extensions/test_ext_request_logging.py:154:16
 ERROR Cannot index into `Mapping[str, object]` [bad-index]
    --> tests/unit_tests/extensions/test_ext_request_logging.py:154:28
-ERROR `in` is not supported between `Literal['needle']` and `object` [not-iterable]
+ERROR `None` is not subscriptable [unsupported-operation]
    --> tests/unit_tests/extensions/test_ext_request_logging.py:155:16
+ERROR Cannot index into `Mapping[str, object]` [bad-index]
+   --> tests/unit_tests/extensions/test_ext_request_logging.py:155:28
+ERROR `in` is not supported between `Literal['needle']` and `object` [not-iterable]
+   --> tests/unit_tests/extensions/test_ext_request_logging.py:156:16
 ERROR `None` is not subscriptable [unsupported-operation]
-   --> tests/unit_tests/extensions/test_ext_request_logging.py:155:31
+   --> tests/unit_tests/extensions/test_ext_request_logging.py:156:31
 ERROR Cannot index into `Mapping[str, object]` [bad-index]
-   --> tests/unit_tests/extensions/test_ext_request_logging.py:155:43
+   --> tests/unit_tests/extensions/test_ext_request_logging.py:156:43
 ERROR `in` is not supported between `Literal['200']` and `object` [not-iterable]
-   --> tests/unit_tests/extensions/test_ext_request_logging.py:209:16
+   --> tests/unit_tests/extensions/test_ext_request_logging.py:210:16
 ERROR `None` is not subscriptable [unsupported-operation]
-   --> tests/unit_tests/extensions/test_ext_request_logging.py:209:25
+   --> tests/unit_tests/extensions/test_ext_request_logging.py:210:25
 ERROR Cannot index into `Mapping[str, object]` [bad-index]
-   --> tests/unit_tests/extensions/test_ext_request_logging.py:209:37
+   --> tests/unit_tests/extensions/test_ext_request_logging.py:210:37
 ERROR `None` is not subscriptable [unsupported-operation]
-   --> tests/unit_tests/extensions/test_ext_request_logging.py:210:16
+   --> tests/unit_tests/extensions/test_ext_request_logging.py:211:16
 ERROR Cannot index into `Mapping[str, object]` [bad-index]
-   --> tests/unit_tests/extensions/test_ext_request_logging.py:210:28
+   --> tests/unit_tests/extensions/test_ext_request_logging.py:211:28
 ERROR `in` is not supported between `Literal['200']` and `object` [not-iterable]
-   --> tests/unit_tests/extensions/test_ext_request_logging.py:227:16
+   --> tests/unit_tests/extensions/test_ext_request_logging.py:228:16
 ERROR `None` is not subscriptable [unsupported-operation]
-   --> tests/unit_tests/extensions/test_ext_request_logging.py:227:25
+   --> tests/unit_tests/extensions/test_ext_request_logging.py:228:25
 ERROR Cannot index into `Mapping[str, object]` [bad-index]
-   --> tests/unit_tests/extensions/test_ext_request_logging.py:227:37
+   --> tests/unit_tests/extensions/test_ext_request_logging.py:228:37
 ERROR `None` is not subscriptable [unsupported-operation]
-   --> tests/unit_tests/extensions/test_ext_request_logging.py:228:16
+   --> tests/unit_tests/extensions/test_ext_request_logging.py:229:16
 ERROR Cannot index into `Mapping[str, object]` [bad-index]
-   --> tests/unit_tests/extensions/test_ext_request_logging.py:228:28
+   --> tests/unit_tests/extensions/test_ext_request_logging.py:229:28
 ERROR `in` is not supported between `Literal['needle']` and `object` [not-iterable]
-   --> tests/unit_tests/extensions/test_ext_request_logging.py:229:16
+   --> tests/unit_tests/extensions/test_ext_request_logging.py:230:16
 ERROR `None` is not subscriptable [unsupported-operation]
-   --> tests/unit_tests/extensions/test_ext_request_logging.py:229:31
+   --> tests/unit_tests/extensions/test_ext_request_logging.py:230:31
 ERROR Cannot index into `Mapping[str, object]` [bad-index]
-   --> tests/unit_tests/extensions/test_ext_request_logging.py:229:43
+   --> tests/unit_tests/extensions/test_ext_request_logging.py:230:43
 ERROR Object of class `Retry` has no attribute `_retries` [missing-attribute]
   --> tests/unit_tests/extensions/test_redis.py:34:16
 ERROR Argument `Flask` is not assignable to parameter `app` with type `DifyApp` in function `extensions.ext_set_secretkey.init_app` [bad-argument-type]
@@ -6982,109 +6982,109 @@
 ERROR Object of class `FromClause` has no attribute `create` [missing-attribute]
    --> tests/unit_tests/services/test_credit_pool_service.py:146:5
 ERROR Argument `SimpleNamespace` is not assignable to parameter `account` with type `Account` in function `services.dataset_service.DatasetService.create_empty_dataset` [bad-argument-type]
-   --> tests/unit_tests/services/test_dataset_service_dataset.py:348:93
+   --> tests/unit_tests/services/test_dataset_service_dataset.py:348:61
 ERROR Argument `SimpleNamespace` is not assignable to parameter `account` with type `Account` in function `services.dataset_service.DatasetService.create_empty_dataset` [bad-argument-type]
-   --> tests/unit_tests/services/test_dataset_service_dataset.py:372:25
+   --> tests/unit_tests/services/test_dataset_service_dataset.py:373:25
 ERROR Argument `SimpleNamespace` is not assignable to parameter `account` with type `Account` in function `services.dataset_service.DatasetService.create_empty_dataset` [bad-argument-type]
-   --> tests/unit_tests/services/test_dataset_service_dataset.py:415:25
+   --> tests/unit_tests/services/test_dataset_service_dataset.py:417:25
 ERROR Argument `SimpleNamespace` is not assignable to parameter `dataset` with type `Dataset` in function `services.dataset_service.DatasetService._update_pipeline_knowledge_base_node_data` [bad-argument-type]
-   --> tests/unit_tests/services/test_dataset_service_dataset.py:736:70
+   --> tests/unit_tests/services/test_dataset_service_dataset.py:731:70
 ERROR Argument `SimpleNamespace` is not assignable to parameter `dataset` with type `Dataset` in function `services.dataset_service.DatasetService._update_pipeline_knowledge_base_node_data` [bad-argument-type]
-   --> tests/unit_tests/services/test_dataset_service_dataset.py:746:70
+   --> tests/unit_tests/services/test_dataset_service_dataset.py:741:70
 ERROR Argument `SimpleNamespace` is not assignable to parameter `dataset` with type `Dataset` in function `services.dataset_service.DatasetService._update_pipeline_knowledge_base_node_data` [bad-argument-type]
-   --> tests/unit_tests/services/test_dataset_service_dataset.py:785:70
+   --> tests/unit_tests/services/test_dataset_service_dataset.py:780:70
 ERROR Argument `SimpleNamespace` is not assignable to parameter `dataset` with type `Dataset` in function `services.dataset_service.DatasetService._update_pipeline_knowledge_base_node_data` [bad-argument-type]
-   --> tests/unit_tests/services/test_dataset_service_dataset.py:808:74
+   --> tests/unit_tests/services/test_dataset_service_dataset.py:803:74
 ERROR Object of class `FakeAccount` has no attribute `current_tenant_id` [missing-attribute]
-   --> tests/unit_tests/services/test_dataset_service_dataset.py:875:9
+   --> tests/unit_tests/services/test_dataset_service_dataset.py:882:9
 ERROR Object of class `FakeAccount` has no attribute `current_tenant_id` [missing-attribute]
-   --> tests/unit_tests/services/test_dataset_service_dataset.py:913:9
+   --> tests/unit_tests/services/test_dataset_service_dataset.py:922:9
 ERROR Argument `None` is not assignable to parameter `embedding_model_provider` with type `str` in function `tests.unit_tests.services.dataset_service_test_helpers.DatasetServiceUnitDataFactory.create_dataset_mock` [bad-argument-type]
-   --> tests/unit_tests/services/test_dataset_service_dataset.py:979:38
+   --> tests/unit_tests/services/test_dataset_service_dataset.py:999:38
 ERROR Argument `None` is not assignable to parameter `embedding_model` with type `str` in function `tests.unit_tests.services.dataset_service_test_helpers.DatasetServiceUnitDataFactory.create_dataset_mock` [bad-argument-type]
-   --> tests/unit_tests/services/test_dataset_service_dataset.py:980:29
+    --> tests/unit_tests/services/test_dataset_service_dataset.py:1000:29
 ERROR Object of class `FakeAccount` has no attribute `current_tenant_id` [missing-attribute]
-    --> tests/unit_tests/services/test_dataset_service_dataset.py:1038:9
+    --> tests/unit_tests/services/test_dataset_service_dataset.py:1069:9
 ERROR Object of class `FakeAccount` has no attribute `current_tenant_id` [missing-attribute]
-    --> tests/unit_tests/services/test_dataset_service_dataset.py:1073:9
+    --> tests/unit_tests/services/test_dataset_service_dataset.py:1106:9
 ERROR Argument `SimpleNamespace` is not assignable to parameter `user` with type `Account | None` in function `services.dataset_service.DatasetService.check_dataset_operator_permission` [bad-argument-type]
-    --> tests/unit_tests/services/test_dataset_service_dataset.py:1384:67
+    --> tests/unit_tests/services/test_dataset_service_dataset.py:1422:22
 ERROR Argument `SimpleNamespace` is not assignable to parameter `dataset` with type `Dataset | None` in function `services.dataset_service.DatasetService.check_dataset_operator_permission` [bad-argument-type]
-    --> tests/unit_tests/services/test_dataset_service_dataset.py:1387:81
+    --> tests/unit_tests/services/test_dataset_service_dataset.py:1430:25
 ERROR Object of class `FakeAccount` has no attribute `id` [missing-attribute]
   --> tests/unit_tests/services/test_dataset_service_document.py:91:9
 ERROR Object of class `FakeAccount` has no attribute `current_tenant_id` [missing-attribute]
   --> tests/unit_tests/services/test_dataset_service_document.py:92:9
 ERROR Argument `SimpleNamespace` is not assignable to parameter `dataset` with type `Dataset` in function `services.dataset_service.DocumentService.update_document_with_dataset_id` [bad-argument-type]
-   --> tests/unit_tests/services/test_dataset_service_document.py:376:65
+   --> tests/unit_tests/services/test_dataset_service_document.py:397:21
 ERROR Argument `SimpleNamespace` is not assignable to parameter `dataset` with type `Dataset` in function `services.dataset_service.DocumentService.update_document_with_dataset_id` [bad-argument-type]
-   --> tests/unit_tests/services/test_dataset_service_document.py:399:65
+   --> tests/unit_tests/services/test_dataset_service_document.py:426:21
 ERROR Argument `SimpleNamespace` is not assignable to parameter `dataset` with type `Dataset` in function `services.dataset_service.DocumentService.update_document_with_dataset_id` [bad-argument-type]
-   --> tests/unit_tests/services/test_dataset_service_document.py:436:70
+   --> tests/unit_tests/services/test_dataset_service_document.py:468:17
 ERROR Argument `SimpleNamespace` is not assignable to parameter `dataset` with type `Dataset` in function `services.dataset_service.DocumentService.update_document_with_dataset_id` [bad-argument-type]
-   --> tests/unit_tests/services/test_dataset_service_document.py:484:65
+   --> tests/unit_tests/services/test_dataset_service_document.py:521:21
 ERROR Argument `SimpleNamespace` is not assignable to parameter `dataset` with type `Dataset` in function `services.dataset_service.DocumentService.update_document_with_dataset_id` [bad-argument-type]
-   --> tests/unit_tests/services/test_dataset_service_document.py:513:70
+   --> tests/unit_tests/services/test_dataset_service_document.py:555:17
 ERROR Argument `SimpleNamespace` is not assignable to parameter `knowledge_config` with type `KnowledgeConfig` in function `services.dataset_service.DocumentService.document_create_args_validate` [bad-argument-type]
-   --> tests/unit_tests/services/test_dataset_service_document.py:534:59
+   --> tests/unit_tests/services/test_dataset_service_document.py:580:59
 ERROR Argument `SimpleNamespace` is not assignable to parameter `knowledge_config` with type `KnowledgeConfig` in function `services.dataset_service.DocumentService.document_create_args_validate` [bad-argument-type]
-   --> tests/unit_tests/services/test_dataset_service_document.py:543:59
+   --> tests/unit_tests/services/test_dataset_service_document.py:589:59
 ERROR Argument `SimpleNamespace` is not assignable to parameter `knowledge_config` with type `KnowledgeConfig` in function `services.dataset_service.DocumentService.data_source_args_validate` [bad-argument-type]
-   --> tests/unit_tests/services/test_dataset_service_document.py:561:55
+   --> tests/unit_tests/services/test_dataset_service_document.py:607:55
 ERROR Argument `SimpleNamespace` is not assignable to parameter `knowledge_config` with type `KnowledgeConfig` in function `services.dataset_service.DocumentService.data_source_args_validate` [bad-argument-type]
-   --> tests/unit_tests/services/test_dataset_service_document.py:582:55
+   --> tests/unit_tests/services/test_dataset_service_document.py:628:55
 ERROR Argument `list[PreProcessingRule] | None` is not assignable to parameter `obj` with type `Sized` in function `len` [bad-argument-type]
-   --> tests/unit_tests/services/test_dataset_service_document.py:633:20
+   --> tests/unit_tests/services/test_dataset_service_document.py:679:20
 ERROR `None` is not subscriptable [unsupported-operation]
-   --> tests/unit_tests/services/test_dataset_service_document.py:634:16
+   --> tests/unit_tests/services/test_dataset_service_document.py:680:16
 ERROR Argument `SimpleNamespace` is not assignable to parameter `knowledge_config` with type `KnowledgeConfig` in function `services.dataset_service.DocumentService.save_document_with_dataset_id` [bad-argument-type]
-   --> tests/unit_tests/services/test_dataset_service_document.py:765:72
+   --> tests/unit_tests/services/test_dataset_service_document.py:850:21
 ERROR `SimpleNamespace` is not assignable to attribute `process_rule` with type `ProcessRule | None` [bad-assignment]
-   --> tests/unit_tests/services/test_dataset_service_document.py:770:41
+   --> tests/unit_tests/services/test_dataset_service_document.py:858:41
 ERROR Argument `SimpleNamespace` is not assignable to parameter `dataset_process_rule` with type `DatasetProcessRule | None` in function `services.dataset_service.DocumentService.save_document_with_dataset_id` [bad-argument-type]
-   --> tests/unit_tests/services/test_dataset_service_document.py:809:38
+   --> tests/unit_tests/services/test_dataset_service_document.py:902:38
 ERROR Argument `SimpleNamespace` is not assignable to parameter `dataset_process_rule` with type `DatasetProcessRule | None` in function `services.dataset_service.DocumentService.save_document_with_dataset_id` [bad-argument-type]
-   --> tests/unit_tests/services/test_dataset_service_document.py:889:38
+   --> tests/unit_tests/services/test_dataset_service_document.py:983:38
 ERROR Argument `SimpleNamespace` is not assignable to parameter `dataset_process_rule` with type `DatasetProcessRule | None` in function `services.dataset_service.DocumentService.save_document_with_dataset_id` [bad-argument-type]
-   --> tests/unit_tests/services/test_dataset_service_document.py:940:38
+    --> tests/unit_tests/services/test_dataset_service_document.py:1035:38
 ERROR Argument `SimpleNamespace` is not assignable to parameter `dataset` with type `Dataset` in function `services.dataset_service.DocumentService.update_document_with_dataset_id` [bad-argument-type]
-    --> tests/unit_tests/services/test_dataset_service_document.py:1094:70
+    --> tests/unit_tests/services/test_dataset_service_document.py:1191:17
 ERROR Argument `SimpleNamespace` is not assignable to parameter `dataset` with type `Dataset` in function `services.dataset_service.DocumentService.update_document_with_dataset_id` [bad-argument-type]
-    --> tests/unit_tests/services/test_dataset_service_document.py:1121:65
+    --> tests/unit_tests/services/test_dataset_service_document.py:1224:21
 ERROR Argument `SimpleNamespace` is not assignable to parameter `dataset` with type `Dataset` in function `services.dataset_service.DocumentService.update_document_with_dataset_id` [bad-argument-type]
-    --> tests/unit_tests/services/test_dataset_service_document.py:1144:65
+    --> tests/unit_tests/services/test_dataset_service_document.py:1252:21
 ERROR Argument `SimpleNamespace` is not assignable to parameter `dataset` with type `Dataset` in function `services.dataset_service.DocumentService.update_document_with_dataset_id` [bad-argument-type]
-    --> tests/unit_tests/services/test_dataset_service_document.py:1159:65
+    --> tests/unit_tests/services/test_dataset_service_document.py:1273:21
 ERROR Argument `SimpleNamespace` is not assignable to parameter `dataset` with type `Dataset` in function `services.dataset_service.DocumentService.update_document_with_dataset_id` [bad-argument-type]
-    --> tests/unit_tests/services/test_dataset_service_document.py:1194:70
+    --> tests/unit_tests/services/test_dataset_service_document.py:1313:17
 ERROR Object of class `NoneType` has no attribute `rules` [missing-attribute]
-    --> tests/unit_tests/services/test_dataset_service_document.py:1551:22
+    --> tests/unit_tests/services/test_dataset_service_document.py:1692:22
 ERROR Argument `SimpleNamespace` is not assignable to parameter `dataset_process_rule` with type `DatasetProcessRule | None` in function `services.dataset_service.DocumentService.save_document_with_dataset_id` [bad-argument-type]
-    --> tests/unit_tests/services/test_dataset_service_document.py:1665:42
+    --> tests/unit_tests/services/test_dataset_service_document.py:1821:42
 ERROR Argument `SimpleNamespace` is not assignable to parameter `dataset_process_rule` with type `DatasetProcessRule | None` in function `services.dataset_service.DocumentService.save_document_with_dataset_id` [bad-argument-type]
-    --> tests/unit_tests/services/test_dataset_service_document.py:1688:42
+    --> tests/unit_tests/services/test_dataset_service_document.py:1845:42
 ERROR Argument `SimpleNamespace` is not assignable to parameter `knowledge_config` with type `KnowledgeConfig` in function `services.dataset_service.DocumentService.save_document_with_dataset_id` [bad-argument-type]
-   --> tests/unit_tests/services/test_dataset_service_lock_not_owned.py:103:26
+   --> tests/unit_tests/services/test_dataset_service_lock_not_owned.py:105:26
 ERROR Argument `SimpleNamespace` is not assignable to parameter `dataset` with type `Dataset` in function `services.dataset_service.SegmentService.create_child_chunk` [bad-argument-type]
-  --> tests/unit_tests/services/test_dataset_service_segment.py:54:97
+  --> tests/unit_tests/services/test_dataset_service_segment.py:58:17
 ERROR Argument `SimpleNamespace` is not assignable to parameter `dataset` with type `Dataset` in function `services.dataset_service.SegmentService.create_child_chunk` [bad-argument-type]
-  --> tests/unit_tests/services/test_dataset_service_segment.py:82:87
+  --> tests/unit_tests/services/test_dataset_service_segment.py:88:87
 ERROR Argument `SimpleNamespace` is not assignable to parameter `dataset` with type `Dataset` in function `services.dataset_service.SegmentService.update_child_chunks` [bad-argument-type]
-   --> tests/unit_tests/services/test_dataset_service_segment.py:129:17
+   --> tests/unit_tests/services/test_dataset_service_segment.py:135:17
 ERROR Argument `SimpleNamespace` is not assignable to parameter `dataset` with type `Dataset` in function `services.dataset_service.SegmentService.update_child_chunks` [bad-argument-type]
-   --> tests/unit_tests/services/test_dataset_service_segment.py:166:21
+   --> tests/unit_tests/services/test_dataset_service_segment.py:173:21
 ERROR Argument `SimpleNamespace` is not assignable to parameter `dataset` with type `Dataset` in function `services.dataset_service.SegmentService.update_child_chunk` [bad-argument-type]
-   --> tests/unit_tests/services/test_dataset_service_segment.py:182:80
+   --> tests/unit_tests/services/test_dataset_service_segment.py:190:80
 ERROR Argument `SimpleNamespace` is not assignable to parameter `dataset` with type `Dataset` in function `services.dataset_service.SegmentService.delete_child_chunk` [bad-argument-type]
-   --> tests/unit_tests/services/test_dataset_service_segment.py:205:64
+   --> tests/unit_tests/services/test_dataset_service_segment.py:213:64
 ERROR Argument `SimpleNamespace` is not assignable to parameter `segment` with type `DocumentSegment` in function `services.dataset_service.SegmentService.update_child_chunk` [bad-argument-type]
-   --> tests/unit_tests/services/test_dataset_service_segment.py:811:49
+   --> tests/unit_tests/services/test_dataset_service_segment.py:833:49
 ERROR Argument `SimpleNamespace` is not assignable to parameter `document` with type `Document` in function `services.dataset_service.SegmentService.update_child_chunk` [bad-argument-type]
-   --> tests/unit_tests/services/test_dataset_service_segment.py:811:68
+   --> tests/unit_tests/services/test_dataset_service_segment.py:833:68
 ERROR Argument `SimpleNamespace` is not assignable to parameter `dataset` with type `Dataset` in function `services.dataset_service.SegmentService.update_child_chunk` [bad-argument-type]
-   --> tests/unit_tests/services/test_dataset_service_segment.py:811:87
+   --> tests/unit_tests/services/test_dataset_service_segment.py:833:87
 ERROR Argument `SimpleNamespace` is not assignable to parameter `dataset` with type `Dataset` in function `services.dataset_service.SegmentService.delete_child_chunk` [bad-argument-type]
-   --> tests/unit_tests/services/test_dataset_service_segment.py:825:60
+   --> tests/unit_tests/services/test_dataset_service_segment.py:847:60
 ERROR Argument `str` is not assignable to parameter `type` with type `Literal['basic', 'bearer', 'custom'] | None` in function `services.entities.external_knowledge_entities.external_knowledge_entities.AuthorizationConfig.__init__` [bad-argument-type]
    --> tests/unit_tests/services/test_external_dataset_service.py:118:60
 ERROR Argument `str` is not assignable to parameter `type` with type `Literal['api-key', 'no-auth']` in function `services.entities.external_knowledge_entities.external_knowledge_entities.Authorization.__init__` [bad-argument-type]

@github-actions

github-actions Bot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Pyrefly Type Coverage

Metric Base PR Delta
Type coverage 51.48% 51.54% +0.06%
Strict coverage 51.00% 51.06% +0.06%
Typed symbols 30,824 30,894 +70
Untyped symbols 29,325 29,319 -6
Modules 2931 2931 0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactor size:XXL This PR changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant