[codex] support TiDB Vector full-text and hybrid search#38112
Open
bkidy wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
Fixes #<issue number>.Summary
Fixes #37145
This PR adds optional full-text and hybrid search support for TiDB Vector.
TIDB_VECTOR_ENABLE_FULLTEXT_SEARCHwith a default offalseso existing TiDB Vector deployments remain semantic-only by default.FULLTEXT INDEX ... WITH PARSER MULTILINGUALon the text column when the feature is enabled.search_by_full_textwithFTS_MATCH_WORD, including document-id filtering and score propagation.Note: I attempted to assign issue #37145 to myself, but GitHub returned
bkidy not foundfor the upstream issue assignment. The issue is still linked here.Screenshots
Checklist
make lint && make type-check(backend) andcd web && pnpm exec vp staged(frontend) to appease the lint godsValidation
PYTHONPATH=api/providers/vdb/vdb-tidb-vector/src api/.venv/bin/python -m pytest -o addopts='' api/providers/vdb/vdb-tidb-vector/tests/unit_tests/test_tidb_vector.py api/tests/unit_tests/controllers/console/datasets/test_datasets.py::TestDatasetRetrievalSettingApi::test_tidb_vector_returns_semantic_only_when_fulltext_disabled api/tests/unit_tests/controllers/console/datasets/test_datasets.py::TestDatasetRetrievalSettingApi::test_tidb_vector_returns_full_methods_when_fulltext_enabled -qgit diff --checkruff format --checkandruff checkon the touched Python filesFrom Codex