refactor: simplify scenario execution by removing complex turn manage… #166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ment - Remove pendingRolesOnTurn, pendingAgentsOnTurn, and turn orchestration logic - Simplify user(), agent(), judge() methods to call agents directly - Replace complex proceed() with simple user→agent→judge loop - Remove scriptCallAgent and callAgent abstraction layers - Keep fail-fast judge evaluation behavior - Reduce code complexity from 682 lines to 136 lines in execution system This maintains the same functionality while dramatically simplifying the codebase.
- Fix reference to this.config.agents instead of this.agents - Remove getter pattern and use this.state.result directly - Implement createUserInput, createAgentInput, and createJudgeInput methods - Add AgentInput import
- Create scenario-execution.utils.ts with ScenarioExecutionUtils export - Move convertAgentReturnTypesToMessages and extractErrorInfo to utils - Update scenario-execution.ts to import and use utils - Improve file structure compliance with single responsibility principle
- Simplify overly verbose class and method documentation - Remove implementation details from API docs - Focus on essential usage information - Keep docs concise and user-focused
drewdrewthis
force-pushed
the
issue165/refactor-scenario-runner-smart-runner-dumb-agents-architecture
branch
from
15dddc2 to
c3cf697
Compare
rogeriochaves
force-pushed
the
main
branch
2 times, most recently
from
77a92af to
9fdb87c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ment
This maintains the same functionality while dramatically simplifying the codebase.