Avoid DDMC cell update prior to implicit capture absorption (bug). - #37
Merged
Conversation
Collaborator
Author
|
This needs a bit more work - its not compatible with MG at the moment. |
RyanWollaeger
force-pushed
the
fix_impcapt_ddmc
branch
2 times, most recently
from
August 8, 2026 00:08
6ac15ef to
fd15986
Compare
Collaborator
Author
This nominally should be ready with the introduction of |
RyanWollaeger
force-pushed
the
fix_impcapt_ddmc
branch
from
August 8, 2026 23:28
fd15986 to
d1a6343
Compare
+ Add [ip,jp,kp]_next to use in ptcl_ddmc_step, to avoid direct particle index update.
RyanWollaeger
force-pushed
the
fix_impcapt_ddmc
branch
from
August 10, 2026 17:53
d1a6343 to
f461c6d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
Description of Changes
ddmc_ptcl_stepChecklist