Use of MeanOpacity in multigroup mode. - #38
Open
RyanWollaeger wants to merge 6 commits into
Open
Conversation
+ Remove use of monochromatic singularity opacity objects. + Employ Mean opacity in frequency_type=multigroup. + Update singularity-opac (to bring in ngroup accessor). + Use *FromNu API for MeanOpacity and MeanScattering in MG. + Parse jaybenne nu-grid in mcblock prior to setting opacity model. Note: the FromNu functions require a binary group search, so it may worth storing group (with or instead of frequency) in the particles.
RyanWollaeger
force-pushed
the
mg_with_mgopac
branch
from
August 13, 2026 16:35
7a3d7a0 to
92a036a
Compare
+ Add good temperature bounds for step_diff_mg_plaw_ddmc.in test.
+ Force scattering bounds to absorption table bounds if true. + Force transport groups to be log centers of absorption bounds if true. Note: as of this changeset some issues remain: - Still assumes log group spacing in table opacity. - There's not yet an option for parsing table scattering opacity.
RyanWollaeger
marked this pull request as ready for review
August 14, 2026 16:57
Collaborator
Author
|
This puts some |
Collaborator
Author
|
Sort of interesting: switching from point evaluation to Rosseland group evaluation in the power-law scattering test seems to still pass (still match with the semi-analytic unit test at the tolerance), without any modification except for ensuring the MeanScattering gets physical temperature bounds. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
Description of Changes
use_opac_grpswhich currently resets the transport groups to the opacity groups, and also sets the scattering groups to the tabular absorption groups if absorption is pre-tabulated and scattering is analytic.Note: scattering is currently always analytic; we will need an option similar to absorption to parse pre-tabulated opacity. In this scenario, if both absorption and scattering are tabular and
use_opac_grps=true, the user would have to ensure the loaded tables have consistent group bounds, barring a remap step. Ifuse_opac_grps=falseand both opacities are tabular, the current changeset will use the particle frequencies to find a possibly different group through each opacity object (which should be okay).TODO
Use gmode in multigroup DDMC evaluations (see commented out gmode in struct).Checklist