Bgclayton simple macaw - #570

Open

jhp-lanl wants to merge 55 commits into

mainfrom

bgclayton_simple_macaw

Commits on Sep 17, 2025

First attempt at implementing an EOS haven't tested compiling yet.
bgclayton-lanl
committed
9758631
Got it compiling, need to test and add more tests.
bgclayton-lanl
committed
53659f8
Working on iterative method for computing density from pressure and temperature.
bgclayton-lanl
committed
edf6a77
Got the nonlinear solve working for density from pressure temp. A few more things to do.
bgclayton-lanl
committed
95b7599
Cleaned up the code some more and added another test.
bgclayton-lanl
committed
5cb1f73
Added documentation for the simple MACAW some more comments.
bgclayton-lanl
committed
d4fdcd1
Reordered the parameters to fix a clang sanitizer issue.
bgclayton-lanl
committed
bd82905
Made suggested changes. A few more thing need to be finalized.
bgclayton-lanl
committed
7e7f432
I think I got all the corrections done.
bgclayton-lanl
committed
fe50dcb
Updated copyright and changelog.
bgclayton-lanl
committed
afc172b

Commits on Sep 18, 2025

Fixed a bug in the isothermal bulk modulus which is also a mistake in the paper
bgclayton-lanl
committed
136ed5e

Commits on Sep 19, 2025

Merge branch 'main' into bgclayton_simple_macaw
Yurlungur
authored
3c3abf9
formatting
jonahm-LANL
committed
aba7fc1
Clang format again?
jhp-lanl
committed
1e5bd4a

Commits on Sep 23, 2025

Commits on Sep 24, 2025

Remove THEN from inside DYNAMIC_SELECTION and add WithinRel comparison
jhp-lanl
committed
e152611
Clang format
jhp-lanl
committed
5909470

Commits on Sep 25, 2025

Remove DYNAMIC_SELECTION macro in case it's the problem
jhp-lanl
committed
8a217b5
Clang format
jhp-lanl
committed
ca76fbd
static cast integer to Real
jhp-lanl
committed
d7656b0
REQUIRE -> CHECK in loop
jhp-lanl
committed
1cf972b
Return cold curve quantities when near cold curve
jhp-lanl
committed
213557b
Clang format
jhp-lanl
committed
5a7ae76
Add const qualifiers to _IsNearOrBelowZero and input
jhp-lanl
committed
342b5fe
Silly mistakes
jhp-lanl
committed
0631d2e
Try epsilon rather than min
jhp-lanl
committed
98c83ce

Commits on Sep 29, 2025

First attempt at implementing an EOS haven't tested compiling yet.
bgclayton-lanl
committed
9d19272
Got it compiling, need to test and add more tests.
bgclayton-lanl
committed
bef66f3
Working on iterative method for computing density from pressure and temperature.
bgclayton-lanl
committed
4854c86
Got the nonlinear solve working for density from pressure temp. A few more things to do.
bgclayton-lanl
committed
9871b93
Cleaned up the code some more and added another test.
bgclayton-lanl
committed
cd1a3fb
Added documentation for the simple MACAW some more comments.
bgclayton-lanl
committed
b553742
Reordered the parameters to fix a clang sanitizer issue.
bgclayton-lanl
committed
1612859
Made suggested changes. A few more thing need to be finalized.
bgclayton-lanl
committed
a1a325a
I think I got all the corrections done.
bgclayton-lanl
committed
2225d78
Updated copyright and changelog.
bgclayton-lanl
committed
42782c5
Fixed a bug in the isothermal bulk modulus which is also a mistake in the paper
bgclayton-lanl
committed
784e671
formatting

jonahm-LANL
authored and
bgclayton-lanl
committed
f316747
Clang format again?

jhp-lanl
authored and
bgclayton-lanl
committed
c68f4fe
Floor values at cold curve to maintain EOS surface

jhp-lanl
authored and
bgclayton-lanl
committed
289ae7c
Remove THEN from inside DYNAMIC_SELECTION and add WithinRel comparison

jhp-lanl
authored and
bgclayton-lanl
committed
88dd6ae
Clang format

jhp-lanl
authored and
bgclayton-lanl
committed
076a48a
Remove DYNAMIC_SELECTION macro in case it's the problem

jhp-lanl
authored and
bgclayton-lanl
committed
c1207f6
Clang format

jhp-lanl
authored and
bgclayton-lanl
committed
ebc41f1
static cast integer to Real

jhp-lanl
authored and
bgclayton-lanl
committed
dbe72a7
REQUIRE -> CHECK in loop

jhp-lanl
authored and
bgclayton-lanl
committed
b114e99
Return cold curve quantities when near cold curve

jhp-lanl
authored and
bgclayton-lanl
committed
90abc66
Clang format

jhp-lanl
authored and
bgclayton-lanl
committed
f7fe261
Add const qualifiers to _IsNearOrBelowZero and input

jhp-lanl
authored and
bgclayton-lanl
committed
4f778d5
Silly mistakes

jhp-lanl
authored and
bgclayton-lanl
committed
2cc5fe3
Try epsilon rather than min

jhp-lanl
authored and
bgclayton-lanl
committed
1145c5f

Commits on Jun 26, 2026