Skip to content

add install check - #649

Closed
Yurlungur wants to merge 6 commits into
mainfrom
jmm/check-installs
Closed

add install check#649
Yurlungur wants to merge 6 commits into
mainfrom
jmm/check-installs

Conversation

@Yurlungur

Copy link
Copy Markdown
Collaborator

PR Summary

Add checks that all header files are installed properly. Thanks @rbberger for the suggestion.

PR Checklist

  • Adds a test for any bugs fixed. Adds tests for new features.
  • Format your changes by using the make format command after configuring with cmake.
  • Document any new features, update documentation for changes made.
  • Make sure the copyright notice on any files you modified is up to date.
  • After creating a pull request, note it in the CHANGELOG.md file.
  • LANL employees: make sure tests pass both on the github CI and on the Darwin CI
  • If ML was used, make sure to add a disclaimer at the top of a file indicating ML was used to assist in generating the file.
  • If Agentic AI was used, have the AI generate a "proposed changes" markdown file and store it in the plan_histories folder, with a filename the same as the MR number.

If preparing for a new release, in addition please check the following:

  • Update the version in cmake.
  • Move the changes in the CHANGELOG.md file under a new header for the new release, and reset the categories.
  • Maintainers: ensure spackages are up to date:
    • LANL-internal team, update XCAP spackages
    • Current maintainer of upstream spackages, submit MR to spack

@Yurlungur
Yurlungur requested review from buechlerm and rbberger August 9, 2026 19:57
@Yurlungur Yurlungur self-assigned this Aug 9, 2026
@Yurlungur Yurlungur added bug Something isn't working build Something to do with the build system labels Aug 9, 2026
constexpr std::int64_t one_as_int = (one << 62) - (one << 52);
// 1./static_cast<double>(as_int(2.0) - as_int(1.0)) == 2^-52
constexpr double scale_down = 2.22044604925031e-16;
constexpr double scale_down = 2.220446049250313e-16;

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't matter much but this literal is actually 2^-52. Had dropped one degree of precision somehow.

@Yurlungur

Copy link
Copy Markdown
Collaborator Author

Miles beat me to it.

@Yurlungur Yurlungur closed this Aug 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working build Something to do with the build system

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants