add install check - #649
Closed
Yurlungur wants to merge 6 commits into
Closed
Conversation
Yurlungur
commented
Aug 9, 2026
| constexpr std::int64_t one_as_int = (one << 62) - (one << 52); | ||
| // 1./static_cast<double>(as_int(2.0) - as_int(1.0)) == 2^-52 | ||
| constexpr double scale_down = 2.22044604925031e-16; | ||
| constexpr double scale_down = 2.220446049250313e-16; |
Collaborator
Author
There was a problem hiding this comment.
Doesn't matter much but this literal is actually 2^-52. Had dropped one degree of precision somehow.
Collaborator
Author
|
Miles beat me to it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Add checks that all header files are installed properly. Thanks @rbberger for the suggestion.
PR Checklist
make formatcommand after configuring withcmake.plan_historiesfolder, with a filename the same as the MR number.If preparing for a new release, in addition please check the following: