Skip to content

Prepare for a bug fix release. - #650

Merged
buechlerm merged 1 commit into
mainfrom
Release-1.12.1
Aug 10, 2026
Merged

Prepare for a bug fix release.#650
buechlerm merged 1 commit into
mainfrom
Release-1.12.1

Conversation

@buechlerm

Copy link
Copy Markdown
Collaborator

PR Summary

Release at 1.12.1 to include the registration of missing headers.

PR Checklist

  • Adds a test for any bugs fixed. Adds tests for new features.
  • Format your changes by using the make format command after configuring with cmake.
  • Document any new features, update documentation for changes made.
  • Make sure the copyright notice on any files you modified is up to date.
  • After creating a pull request, note it in the CHANGELOG.md file.
  • LANL employees: make sure tests pass both on the github CI and on the Darwin CI
  • If ML was used, make sure to add a disclaimer at the top of a file indicating ML was used to assist in generating the file.
  • If Agentic AI was used, have the AI generate a "proposed changes" markdown file and store it in the plan_histories folder, with a filename the same as the MR number.

If preparing for a new release, in addition please check the following:

  • Update the version in cmake.
  • Move the changes in the CHANGELOG.md file under a new header for the new release, and reset the categories.
  • Maintainers: ensure spackages are up to date:
    • LANL-internal team, update XCAP spackages
    • Current maintainer of upstream spackages, submit MR to spack

@buechlerm

Copy link
Copy Markdown
Collaborator Author

What are the remaining steps? Create the tag and a github release, etc?

@Yurlungur Yurlungur left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Did both #647 and #648 make it in? If so, this is good to go and I'll cut the release.

We will also need to update spack.

@Yurlungur

Copy link
Copy Markdown
Collaborator

What are the remaining steps? Create the tag and a github release, etc?

Yes if you click on the release thingy on the right bar, you can create a release after this is merged. I typically use the changelog for the release notes. You can create a tag inline when you make the release.

Then we need to submit an MR to xcap-spackages and to spack upstream each. If you're interested in doing that stuff, it's appreciated, if not I can do it.

@buechlerm

Copy link
Copy Markdown
Collaborator Author

Yes, I'll do it. I have an MR in to xcap-spackages to patch 1.12.0. I'll add 1.12.1 in that MR unless there are objections to combining them.

@buechlerm
buechlerm merged commit 760ac3f into main Aug 10, 2026
10 checks passed
@buechlerm
buechlerm deleted the Release-1.12.1 branch August 10, 2026 14:25
@Yurlungur

Copy link
Copy Markdown
Collaborator

Combining them sounds good to me. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants