Apply codex-gpt5.6 fix (via A. Dempsey) to physical constants API. - #79
Merged
Conversation
RyanWollaeger
commented
Aug 6, 2026
RyanWollaeger
commented
Collaborator
- Apply codex patch to GetRuntimePhysicalConstants in non-cgs.
- codex added unit tests as well...
- Also (not AI): add non-cgs Emissivity (just for consistency).
+ Apply codex patch to GetRuntimePhysicalConstants in non-cgs. + Also (not AI): add non-cgs Emissivity (just for consistency).
adamdempsey90
approved these changes
Aug 6, 2026
adamdempsey90
left a comment
adamdempsey90
left a comment
Collaborator
There was a problem hiding this comment.
It's a beautiful thing
Collaborator
Author
|
Will go ahead and merge this - since it has the approval - feel free to tweak later of course (sorry for haste). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.