Add gray data to converted IPCRESS file - #80
Open
alexrlongne wants to merge 3 commits into
Open
Conversation
+ Add function to interpolate gray opacities to interpolate_opacity.hpp + Add function to create a gray databox + Add keywords for gray opacity to list of databoxes to make + Move keyword definitions from spiner (not commited) to the singularity-opac/base/sp5.hpp file (similar to singularity-eos) + Fix type for print flag to be bool instead of double
+ Add converted file + Remove option for log interpolation and always use log interpolation + Add multiplier for interpolation points in spiner DataBox tables + Add gray opacity interpolation + Test interpolated values against Draco ipcress interpolated values
Yurlungur
reviewed
Aug 12, 2026
Collaborator
There was a problem hiding this comment.
We may not want to keep the test file in the repo as keeping hdf5 under version control can add up to big diffs over time. I would instead suggest stashing this in a release, similar to how we do things with singularity-eos. I can create a release containing just this file if you want.
Contributor
Author
There was a problem hiding this comment.
I see the release with the gold files. Is there a cmake example you can point me to that grabs those files and puts them in the test directory?
alexrlongne
commented
Aug 13, 2026
| // ====================================================================== | ||
| #ifndef SINGULARITY_OPAC_BASE_SP5_ | ||
| #define SINGULARITY_OPAC_BASE_SP5_ | ||
| // This file was made in part with generative AI. |
Contributor
Author
There was a problem hiding this comment.
Putting this back in as I just added my own stuff.
alexrlongne
force-pushed
the
feature/ipcress2spiner_add_gray
branch
from
August 13, 2026 04:04
0164b21 to
bced6d9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
Changes