Add void return type hints to console commands#295
Merged
taylorotwell merged 1 commit intolaravel:2.xfrom Mar 26, 2026
Merged
Conversation
Improves type safety and ensures compatibility with `Symfony\Component\Console\Command\Command::configure(): void` to fix #294
msonowal
added a commit
to msonowal/docker-php-node
that referenced
this pull request
Mar 26, 2026
Use laravel/envoy:2.x-dev to pull the unreleased fix for void return type hints on console commands (laravel/envoy#295). Co-Authored-By: jupitora <84776679+boruah@users.noreply.github.com>
|
Any chance we could get a release with this PR? After upgrading to Laravel v13 my envoy deploys are failing on this. |
Contributor
Author
|
hi @dinandmentink, for short term solution you can try the msonowals workaround (above): msonowal/docker-php-node@69dca7d |
|
@dominosaurs Yes, that would work, thanks for the suggestion. I was kinda hoping for a quick minor release, so I don't have to go through a bunch of codebases and revert the dev version again, this being a first-party laravel package that now breaks for all laravel 13 installs. Anyway, the horror, I'll live. Thanks for the quick fix! |
msonowal
added a commit
to msonowal/docker-php-node
that referenced
this pull request
Mar 28, 2026
* Upgrade PHP version to 8.5 in Dockerfile Updated PHP version in Dockerfile from 8.4 to 8.5. * Update README.md * Update docker-image.yml Update Node version to v22 in README Update PHP version in README tags section Update Node version to v24 in README Fix envoy compatibility with Symfony Console v8 on PHP 8.5 Use laravel/envoy:2.x-dev to pull the unreleased fix for void return type hints on console commands (laravel/envoy#295). Co-Authored-By: jupitora <84776679+boruah@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improves type safety and ensures compatibility with
Symfony\Component\Console\Command\Command::configure(): voidto fix #294