fix(drive): stop file iterator on empty page token - #226
Open
ZYZ666-RGB wants to merge 1 commit into
Open
Conversation
|
|
Author
|
Hi maintainers, just following up on this PR. The CLA is complete, the focused iterator tests pass, and the change fixes #220. Please let me know if any changes or additional tests are needed. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ListFileIteratorProblem
ListFileIterator.Next()currently stops only whenNextPageTokenis nil.The Drive API may return a non-nil pointer containing an empty string on the final page. In that case, the iterator sends another request with an empty
page_token, which may repeat pagination until the caller's context times out.Testing
Added focused unit tests covering:
Fixes #220