feat(SPEC-044): free local models while a remote endpoint is selected - #116
Merged
Merged
Conversation
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SPEC
SPEC-044 (Remote transcription endpoint)
Milestone
M3
Why
On the remote backend no local model is loaded, yet Settings still refused to delete the selected one (
large-v3= ~3 GB) — disk the user cannot reclaim while nothing uses it.Change
SpeechModelCatalog.canDelete(variant:selected:loaded:remoteBackend:dictating:)— pure rule: local backend protects selected + loaded, remote protects nothing, any in-flight dictation protects allAppState.isDictatingextracted so the view and the delegate share one definitionTests
SpeechModelCatalogTests: local protection, remote frees selection, dictation protects both backendsswift build && swift testgreen locally (304 tests)Privacy impact
None — local disk/memory management only; no change to what leaves the machine.
Out of scope
Auto-clearing the model selection when its files are deleted (selection stays, download resumes on switch-back).
🤖 Generated with Claude Code