Repository navigation
Retain audit diagnostics and post bundle results to Discord - #145
Open
ShivanshuPurohit wants to merge 2 commits into
Open
ShivanshuPurohit wants to merge 2 commits into
ShivanshuPurohit wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bundle results currently require opening the dashboard or inspecting worker output; Discord only reports weight activation. Extend the existing webhook monitor to post each new PASS, FAIL, HOLD, or expiry with its reason, measured/required speed, replay count, audit summary, reward eligibility, and an arena-scoped details/logs link. Existing history is seeded without flooding the channel; successful deliveries survive ordinary restarts and failed sends retry.
Failed node-audit windows now retain their row errors, reference noise, and actual applied tolerance in the existing worker log. One-shot build stdout joins stderr, and successful build diagnostics are retained instead of deleted. Verdicts and tolerances are unchanged. Diagnostic limits and truncation are explicit; old measurements that were never emitted cannot be recovered.
Consumers: the existing
weight_reveal_monitorentrypoint, node audit dispatcher, andOCIProcessManager.run. Casualties: weights-only result visibility, rolling-only audit detail, discarded successful build logs, and stdout sent to/dev/null. VM paths, disk cleanup, and log-copy service configuration remain private operator configuration outside this PR.Validation: 60 focused tests passed, 1 existing skip; reachability, line/assertion ratchets, surface snapshot, documentation checks, and strict MkDocs build passed. No GPU qualification was rerun, and this does not claim hardware validation of the new audit diagnostics.
Line accounting: production +178/-36 (net +142); tests +173/-7 (net +166); documentation +38/-0. The existing oversized OCI module shrinks by 19 lines; its ceiling is lowered. Directory ceilings rise only for these bounded changes.
surface-change: modules — add the two bundle-result helpers and failed-window diagnostic function; no wire, verdict, catalog, or CLI-root identity changes.
Live operator verification: updated webhook monitor deployed and a real failed-bundle result accepted by Discord; read-only dashboard audit summaries deployed. Runtime log-copy service and storage relocation are private VM configuration, not repository changes.