Skip to content

perf: some small refactors to improve perf #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
latonis merged 2 commits into from
May 17, 2026
Merged

perf: some small refactors to improve perf #15

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c8b1ec1
perf: only push prefix when not empty
latonis May 17, 2026
4c9aaef
refactor: no deep clone for val
latonis May 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,8 +96,10 @@ impl<'a> Flattener<'a> {
/// A formatted key string with the separator inserted between prefix and suffix.
fn build_key(&self, prefix: &str, suffix: &str) -> String {
let mut key = String::with_capacity(prefix.len() + self.separator.len() + suffix.len());
key.push_str(prefix);
key.push_str(self.separator);
if !prefix.is_empty() {
key.push_str(prefix);
key.push_str(self.separator);
}
key.push_str(suffix);
key
}
Expand Down Expand Up @@ -213,7 +215,7 @@ impl<'a> Flattener<'a> {
if let Some(array) = value.as_array_mut() {
array.push(obj.clone());
} else {
let existing = value.clone();
let existing = std::mem::take(value);
*value = json!(vec![existing, obj.clone()]);
}
}
Expand Down Expand Up @@ -560,7 +562,7 @@ mod tests {
});
let result: Value = flattener.flatten(&input);

assert_eq!(result, json!({"": ["a", "b"], ".b": "1"}));
assert_eq!(result, json!({"": ["a", "b"], "b": "1"}));
}

#[test]
Expand Down