feat: add internal BigSegmentStoreWrapper with caching and status polling#543
Conversation
We'll want to determine if we should update the spec here or the implementations. It does sound reasonably though. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
There are 2 total unresolved issues (including 1 from previous review).
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit c13f1d8. Configure here.
…ring in-flight query
I've added it to the list of follow-ups where java and the spec aren't in alignment. |
🤖 I have created a release *beep* *boop* --- <details><summary>launchdarkly-cpp-client: 3.11.2</summary> ## [3.11.2](launchdarkly-cpp-client-v3.11.1...launchdarkly-cpp-client-v3.11.2) (2026-06-29) ### Dependencies * The following workspace dependencies were updated * dependencies * @launchdarkly/cpp-internal bumped from 0.13.0 to 0.14.0 * @launchdarkly/cpp-common bumped from 1.11.0 to 1.12.0 * @launchdarkly/cpp-sse-client bumped from 0.6.1 to 0.7.0 </details> <details><summary>launchdarkly-cpp-common: 1.12.0</summary> ## [1.12.0](launchdarkly-cpp-common-v1.11.0...launchdarkly-cpp-common-v1.12.0) (2026-06-29) ### Features * expose Big Segments via public Client and Config APIs ([#552](#552)) ([c5fd239](c5fd239)) </details> <details><summary>launchdarkly-cpp-internal: 0.14.0</summary> ## [0.14.0](launchdarkly-cpp-internal-v0.13.0...launchdarkly-cpp-internal-v0.14.0) (2026-06-29) ### Features * add internal BigSegmentStoreWrapper with caching and status polling ([#543](#543)) ([47fa5c2](47fa5c2)) * orchestrator switches to FDv1 fallback on directive ([#539](#539)) ([44f2522](44f2522)) ### Bug Fixes * FDv2 fixes surfaced by v3 contract test harness ([#547](#547)) ([e9c3c04](e9c3c04)) * handle FDv2 intentCode none as listening, reject unknown codes ([#555](#555)) ([42e8ecd](42e8ecd)) ### Dependencies * The following workspace dependencies were updated * dependencies * @launchdarkly/cpp-common bumped from 1.11.0 to 1.12.0 </details> <details><summary>launchdarkly-cpp-server: 3.11.0</summary> ## [3.11.0](launchdarkly-cpp-server-v3.10.1...launchdarkly-cpp-server-v3.11.0) (2026-06-29) ### Features * add FDv1AdapterSynchronizer wrapping IDataSynchronizer as IFDv2Synchronizer ([#540](#540)) ([d6368b8](d6368b8)) * add FDv2 configuration builder ([#545](#545)) ([43850ce](43850ce)) * add IBigSegmentStore interface + Redis and DynamoDB stores ([#536](#536)) ([136aca7](136aca7)) * add internal BigSegmentsBuilder + config struct ([#541](#541)) ([3c88c2a](3c88c2a)) * add internal BigSegmentStoreWrapper with caching and status polling ([#543](#543)) ([47fa5c2](47fa5c2)) * add server FDv2 data system orchestrator ([#529](#529)) ([65e110f](65e110f)) * add X-LaunchDarkly-Instance-Id header to server SDK (SDK-2353) ([#532](#532)) ([fd0c761](fd0c761)) * evaluate big segments ([#550](#550)) ([505ee46](505ee46)) * expose Big Segments via public Client and Config APIs ([#552](#552)) ([c5fd239](c5fd239)) * orchestrator switches to FDv1 fallback on directive ([#539](#539)) ([44f2522](44f2522)) * propagate FDv1 fallback directive from FDv2 polling and streaming sources ([#538](#538)) ([edd96fe](edd96fe)) ### Bug Fixes * FDv2 fixes surfaced by v3 contract test harness ([#547](#547)) ([e9c3c04](e9c3c04)) * stop accumulating WhenAny continuations on the Conditions aggregate ([#562](#562)) ([5f8bf79](5f8bf79)) ### Dependencies * The following workspace dependencies were updated * dependencies * @launchdarkly/cpp-internal bumped from 0.13.0 to 0.14.0 * @launchdarkly/cpp-common bumped from 1.11.0 to 1.12.0 * @launchdarkly/cpp-sse-client bumped from 0.6.1 to 0.7.0 </details> <details><summary>launchdarkly-cpp-server-dynamodb-source: 0.2.0</summary> ## [0.2.0](launchdarkly-cpp-server-dynamodb-source-v0.1.0...launchdarkly-cpp-server-dynamodb-source-v0.2.0) (2026-06-29) ### Features * add IBigSegmentStore interface + Redis and DynamoDB stores ([#536](#536)) ([136aca7](136aca7)) * add internal BigSegmentStoreWrapper with caching and status polling ([#543](#543)) ([47fa5c2](47fa5c2)) * implement DynamoDBDataSource + tests ([#534](#534)) ([a0c2790](a0c2790)) * scaffold libs/server-sdk-dynamodb-source ([#533](#533)) ([df386c1](df386c1)) ### Dependencies * The following workspace dependencies were updated * dependencies * @launchdarkly/cpp-server bumped from 3.10.1 to 3.11.0 </details> <details><summary>launchdarkly-cpp-server-otel: 0.1.2</summary> ## [0.1.2](launchdarkly-cpp-server-otel-v0.1.1...launchdarkly-cpp-server-otel-v0.1.2) (2026-06-29) ### Dependencies * The following workspace dependencies were updated * dependencies * @launchdarkly/cpp-server bumped from 3.10.1 to 3.11.0 </details> <details><summary>launchdarkly-cpp-server-redis-source: 2.3.0</summary> ## [2.3.0](launchdarkly-cpp-server-redis-source-v2.2.2...launchdarkly-cpp-server-redis-source-v2.3.0) (2026-06-29) ### Features * add IBigSegmentStore interface + Redis and DynamoDB stores ([#536](#536)) ([136aca7](136aca7)) * add internal BigSegmentStoreWrapper with caching and status polling ([#543](#543)) ([47fa5c2](47fa5c2)) ### Dependencies * The following workspace dependencies were updated * dependencies * @launchdarkly/cpp-server bumped from 3.10.1 to 3.11.0 </details> <details><summary>launchdarkly-cpp-sse-client: 0.7.0</summary> ## [0.7.0](launchdarkly-cpp-sse-client-v0.6.1...launchdarkly-cpp-sse-client-v0.7.0) (2026-06-29) ### Features * propagate FDv1 fallback directive from FDv2 polling and streaming sources ([#538](#538)) ([edd96fe](edd96fe)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > The diff is mechanical versioning and changelog updates only; functional risk is whatever shipped in prior commits now being tagged, not new logic in this PR. > > **Overview** > This PR is a **Release Please** cut that updates `.release-please-manifest.json`, workspace `package.json` dependency pins, CMake `VERSION` lines, embedded SDK version strings, version assertion tests, and **CHANGELOG** entries—no feature or bugfix code appears in the diff itself. > > The release packages **server SDK 3.11.0** (FDv2 orchestration/config, FDv1 fallback from streaming/polling, big-segment evaluation and public APIs, Redis/DynamoDB `IBigSegmentStore`, `X-LaunchDarkly-Instance-Id`), plus **client 3.11.2** and bumps for **common 1.12.0**, **internal 0.14.0**, **SSE 0.7.0**, **redis-source 2.3.0**, **dynamodb-source 0.2.0**, and **otel 0.1.2**. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit 48e3593. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY --> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Summary
Internal layer between the evaluator and a customer-provided
IBigSegmentStore: hashes context keys, caches membership lookups, polls thestore's metadata in the background to track availability/staleness, and
broadcasts status changes. No caller yet — the evaluator and the public status
provider come later in the stack.
Design notes
base64(sha256(key))using the standard base64alphabet (not the existing URL-safe
Base64UrlEncode), so the lookup keymatches what the Relay Proxy writes.
than each hitting the store.
async::Delay+CancellationSource.unavailable. The spec requires this; the Java and Go SDKs don't do it, so this
is a deliberate divergence.
StoreMetadata::last_up_to_datefrom a baremillisecondsto asystem_clock::time_point, so staleness math can't mix epochs. This touchesthe Redis and DynamoDB stores (one line each) and their metadata tests.
Test plan
Note
Medium Risk
Changes the public
IBigSegmentStorecontract (noexcept,StoreMetadatatype) and adds threaded/async polling plus store-error handling that affects how staleness and availability are reported; evaluator is not wired yet, limiting immediate eval impact.Overview
Adds
BigSegmentStoreWrapper, the internal layer in front ofIBigSegmentStore: hashes context keys asbase64(sha256(key))via newBase64Encode(RFC 4648, not URL-safe), uses an LRU/TTLMembershipCache, coalesces concurrent lookups for the same key, polls metadata on a timer for availability/staleness, and broadcasts status changes. Membership lookups returnBigSegmentsStatus(healthy/stale/store error); a failed lookup marks the store unavailable (per spec).StoreMetadata::last_up_to_dateis now asystem_clock::time_pointinstead of raw milliseconds; Redis and DynamoDB stores and their tests are updated accordingly.IBigSegmentStore::GetMembership/GetMetadataarenoexcept, with DynamoDB wrapping AWS calls in try/catch.Supporting pieces:
big_segments_status.hpp,#include <variant>inpromise.hpp, and unit tests for the wrapper, cache, and standard base64.Reviewed by Cursor Bugbot for commit 0b492dd. Bugbot is set up for automated code reviews on this repo. Configure here.