feat: serve flag overrides while uninitialized and mark override evaluations in events#410
Draft
kinyoklion wants to merge 2 commits into
Draft
Conversation
…uations in events
…/client-override-wiring
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completes the client-side behavior of the override system:
FlagEventPropertiesfor both top-level and prerequisite evaluations, which is what drives the events pipeline's separate override summary counters and its suppression of individual feature/debug events (feat: mark override evaluations in summary counters and suppress their individual events go-sdk-events#54).Client-level tests cover the gate matrix (overridden vs. not, with removal), the AllFlagsState three-way branch, the event marker, the marked evaluation reason end-to-end, and flag-change notifications firing when overrides change on a running client.
go.mod points at pseudo-versions of the in-flight go-server-sdk-evaluation and go-sdk-events branches; those get pinned to real releases at the end of the series.
Based on #409.
SDK-2655