fix: custom featureStores in FDv2 does not get wrapped as TransactionalFeatureStore.#1812
Merged
Merged
Conversation
Contributor
|
@launchdarkly/js-sdk-common size report |
Contributor
|
@launchdarkly/js-client-sdk size report |
Contributor
|
@launchdarkly/browser size report |
Contributor
|
@launchdarkly/js-client-sdk-common size report |
TransactionalFeatureStore.
joker23
force-pushed
the
skz/sdk-2733/custom-persistent-store-init
branch
from
July 21, 2026 14:05
2310f09 to
2125f36
Compare
joker23
marked this pull request as ready for review
July 21, 2026 14:42
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
tanderson-ld
approved these changes
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Changes core feature-store wiring for FDv2 data system configs; incorrect wrapping could affect flag payload consistency for custom persistent stores.
Overview
FDv2
dataSystem.persistentStorehandling now always returns anLDTransactionalFeatureStore. FDv1-only stores (e.g. Redis/Dynamo integrations withoutapplyChanges) are wrapped inTransactionalFeatureStoreso FDv2 updates no longer throwapplyChanges is not a function. Stores that already exposeapplyChangesare returned unchanged so native transactional behavior is preserved. The same logic applies when the store is provided as a factory.TransactionalFeatureStoreforwardsgetSelectorandgetInitMetaDatafrom its in-memory layer so selector/init metadata stay correct before and after a basis, without surfacing metadata written only on the underlying persistence store pre-basis.Tests cover Configuration wrapping/pass-through and transactional metadata/selector behavior.
Reviewed by Cursor Bugbot for commit 2125f36. Bugbot is set up for automated code reviews on this repo. Configure here.