Skip to content

test: fix contract tests #1813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
joker23 wants to merge 2 commits into from
Closed

test: fix contract tests #1813

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
abfab91
chore: disable secure hashing capability in electron contract test
joker23 Jul 20, 2026
40b1e86
test: fix contract test client entities
joker23 Jul 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions packages/sdk/browser/contract-tests/entity/src/ClientEntity.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -296,6 +296,9 @@ export class ClientEntity {
if (!customEventParams) {
throw malformedCommand;
}
if (customEventParams.user || customEventParams.context) {
await this._client.identify(customEventParams.user || customEventParams.context);
}
this._client.track(
customEventParams.eventKey,
customEventParams.data,
Expand Down
3 changes: 3 additions & 0 deletions packages/sdk/electron/contract-tests/entity/src/ClientEntity.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,6 +236,9 @@ export class ClientEntity {
if (!customEventParams) {
throw malformedCommand;
}
if (customEventParams.user || customEventParams.context) {
await this._client.identify(customEventParams.user || customEventParams.context);
}
this._client.track(
customEventParams.eventKey,
customEventParams.data,
Expand Down
1 change: 0 additions & 1 deletion packages/sdk/electron/contract-tests/entity/src/main.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@ const capabilities = [
'client-per-context-summaries',
'track-hooks',
'tls:skip-verify-peer',
'secure-mode-hash',
'event-gzip',

/// ////////////////////////////
Expand Down
3 changes: 3 additions & 0 deletions packages/sdk/node-client/contract-tests/src/sdkClientEntity.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -319,6 +319,9 @@ export async function newSdkClientEntity(options: CreateInstanceParams): Promise
if (!pce) {
throw malformedCommand;
}
if (pce.user || pce.context) {
await client.identify((pce.user as LDContext) || (pce.context as LDContext));
}
client.track(pce.eventKey, pce.data, pce.metricValue);
return undefined;
}
Expand Down
3 changes: 3 additions & 0 deletions packages/sdk/react-native/contract-tests/entity/src/ClientEntity.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -296,6 +296,9 @@ export class ClientEntity {
if (!customEventParams) {
throw malformedCommand;
}
if (customEventParams.user || customEventParams.context) {
await this._client.identify(customEventParams.user || customEventParams.context);
}
this._client.track(
customEventParams.eventKey,
customEventParams.data,
Expand Down
3 changes: 3 additions & 0 deletions packages/sdk/react/contract-tests/app/ClientEntity.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,6 +157,9 @@ export async function doCommand(client: LDReactClient, params: CommandParams): P
if (!customEventParams) {
throw malformedCommand;
}
if (customEventParams.user || customEventParams.context) {
await client.identify(customEventParams.user || customEventParams.context);
}
client.track(
customEventParams.eventKey,
customEventParams.data,
Expand Down
Loading