Skip to content

Badges Functionality + badge overview#32

Open
bkatler wants to merge 3 commits intomainfrom
badges
Open

Badges Functionality + badge overview#32
bkatler wants to merge 3 commits intomainfrom
badges

Conversation

@bkatler
Copy link
Collaborator

@bkatler bkatler commented Apr 19, 2025

In this PR:

  • Added Badges for the following achievements: Creating 1, 5, or 10 stacks, Getting 5, 25, or 100 points, and Getting a 5, 15, or 30 day streak.
  • When a user gets a badge, a pop-up comes on their screen which shows the badge and explains it
  • Users can only get badges once
  • To view badges, they hit the Badge Gallery Overview button on Profile (Profile is a slightly old version, will merge main back into here once the profile pr is approved)
  • Badge Gallery Overview allows users to see all badges they have
  • I added an animation which transitions across badges

I think it makes more sense to do profile pr first especially because it's only a few minor changes. When that happens I'll merge main in here and fix any conflicts asap :)

@bkatler bkatler requested review from giselleeliasi, laurenindira and raihanaza and removed request for laurenindira and raihanaza April 19, 2025 18:57
Copy link
Owner

@laurenindira laurenindira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

immediately obvious issues addressed, i need to test more on my end to comment on the logic. however, there was enough to submit an initial review

@bkatler
Copy link
Collaborator Author

bkatler commented Apr 24, 2025

Resolved all issues, full notes:

  • Restored all accidentally deleted credits, comments, and TODOs
  • Removed default value of earnedBadges from User Model
  • Removed all logic requiring firebase and Firestore inside CardStackView and created a helper function called updateStreakAndCheckForBadge() inside AuthViewModel
  • Removed extra custom button from nav on ContentView
  • Some other minor changes (e.g. restored previews, weird formatting stuff)

@bkatler bkatler requested a review from laurenindira April 24, 2025 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants