fix: use the shared Card style for the live-output console container#846
Merged
Conversation
The console's outer Border was a one-off (CornerRadius 6) that duplicated the
Card style's surface/border but with a smaller radius than every other card.
Switched it to Style={StaticResource Card} (same Surface1 background, Border1
brush, 1px border, 10px radius) while keeping Padding=0 — the toolbar and output
list manage their own spacing, so the console stays flush with no extra inner
gap. Visual change is the corner radius (6 -> 10), bringing it in line with the
surrounding cards on App Updates, Cleanup, System Health, and Windows Update.
Verified by launching the published build and inspecting the Cleanup tab: the
console card's corners, padding, and alignment match the sibling cards.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Audit Round 7 (uniformity) — finishes finding #7. The live-output console's outer
Borderwas a one-off (CornerRadius="6") duplicating theCardstyle's surface/border but with a smaller radius than every other card. Switched it toStyle="{StaticResource Card}"(same Surface1 background, Border1 brush, 1px border, 10px radius), keepingPadding="0"since the toolbar and output list manage their own spacing.The only visual change is the corner radius (6 → 10), bringing the console in line with the surrounding cards on App Updates, Cleanup, System Health, and Windows Update.
Why this was deferred earlier
In PR #839 I skipped the Card swap because
CardcarriesPadding="16"and the console intentionally usesPadding="0"— a blind swap risked injecting inner padding on four host views. This PR does it safely by overridingPadding="0"on the styled Border, so the radius unifies but the zero inner gap is preserved.Verification
Notes
fix:(user-visible styling) — version bumped to 1.20.13, CHANGELOG updated in this PR. Triggers a release.