refactor: use [LibraryImport] for SHEmptyRecycleBin#853
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Converts the
SHEmptyRecycleBinP/Invoke from the runtime-marshalled[DllImport]to the source-generated
[LibraryImport]. Behavior is identical — the generatoremits the same UTF-16, W-suffixed entry-point call, just with the marshalling stub
produced at build time instead of by the runtime.
Change
Services/TuneUpService.cs:TuneUpServiceand its nestedNativeMethodsare nowpartial(required so thegenerator can emit the implementation).
[DllImport("shell32.dll", CharSet = CharSet.Unicode)] static extern→[LibraryImport("shell32.dll", StringMarshalling = StringMarshalling.Utf16, EntryPoint = "SHEmptyRecycleBinW")] static partial.Why identical
CharSet.Unicode⇒StringMarshalling.Utf16— same UTF-16 string marshalling.EntryPoint = "SHEmptyRecycleBinW"names the exact W-suffixed export thatCharSet.Unicodewas already selecting implicitly.IntPtr,uint,intHRESULT return) — nomarshalling behavior changes. Neither the old nor new declaration sets
SetLastError, so error handling (thehr >= 0 || 0x80070012check) is unchanged.Not converted (deliberately)
The other two
[DllImport]s —SHGetFileInfo(ref SHFILEINFO,ByValTStrinlinebuffers) and
SHFileOperation(ref SHFILEOPSTRUCT,LPWStrfields) — passnon-blittable structs the source generator cannot marshal without a custom
[NativeMarshalling]rewrite, which would not be byte-identical. They stay[DllImport].Verification
accepted the signature).
Behavior identical (Protocol Q).
refactor:→ no release.