refactor: drop two orphan DI registrations for static-only services#854
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes two dead DI registrations.
IconExtractorServiceandServiceManagerServiceexpose only static members and every call site is a static call — the container
constructed an unused empty singleton of each at startup that nothing ever resolved.
Deleting the registrations removes that dead wiring without touching any call site.
Changes
ServiceRegistration.cs:services.AddSingleton<IconExtractorService>();services.AddSingleton<ServiceManagerService>();Both classes remain exactly as-is (static utility classes); all static call sites are
untouched.
Why this is safe / behavior-identical
(
GetService/GetRequiredService) or constructor-injected anywhere — both arepure static-method utilities. The build proves there is no compile-time dependency.
new-ing one unused instance ofeach on first build of the provider; nothing read those instances, so removing them
changes no observable behavior.
Note:
AppBlockerService— flagged alongside these in the original audit — is notan orphan anymore; it was converted to an injected instance behind
IAppBlockerServicein an earlier PR and is correctly registered. Left untouched.
Verification
Behavior identical (Protocol Q).
refactor:→ no release.