Skip to content

Cleaned up VS2022 project and added proper x64 / ARM64 / ARM64X targets #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Arakula wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Cleaned up VS2022 project and added proper x64 / ARM64 / ARM64X targets #124

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
54e9fff
Cleaned up VS2022 project and added proper x64 / ARM64 / ARM64X targets
Arakula Sep 1, 2025
6029a66
Further VS2022 project cleanups
Arakula Sep 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/regcomp.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ tre_regncomp(regex_t *preg, const char *regex, size_t n, int cflags)
#endif /* HAVE_MBSTATE_T */
while (n > 0)
{
consumed = tre_mbrtowc(wcptr, regex, n, &state);
consumed = (int)tre_mbrtowc(wcptr, regex, n, &state);

@dag-erling dag-erling Dec 22, 2025

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should no longer be needed, #128 changed consumed to size_t.


switch (consumed)
{
Expand All @@ -77,7 +77,7 @@ tre_regncomp(regex_t *preg, const char *regex, size_t n, int cflags)
case -2:
/* The last character wasn't complete. Let's not call it a
fatal error. */
consumed = n;
consumed = (int)n;

@dag-erling dag-erling Dec 22, 2025

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above.

break;
}
regex += consumed;
Expand Down
2 changes: 1 addition & 1 deletion lib/tre-compile.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1884,7 +1884,7 @@ tre_compile(regex_t *preg, const tre_char_t *regex, size_t n, int cflags)
parse_ctx.mem = mem;
parse_ctx.stack = stack;
parse_ctx.re = regex;
parse_ctx.len = n;
parse_ctx.len = (int)n;

@dag-erling dag-erling Dec 22, 2025

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should no longer be needed once #129 goes in

parse_ctx.cflags = cflags;
parse_ctx.max_backref = -1;
/* Use 8-bit optimizations in 8-bit mode */
Expand Down
Loading