Move headers back and fix Windows build - #140
Merged
Merged
Conversation
Normalize the top-of-file comment and include guard in all our headers. No functional change intended.
This was never a good idea, and it is moot now anyway since the stated reason for it (the python extension module) is currently unbuildable.
Request slightly newer versions of autoconf and gettext to silence warnings from automake.
* Add missing x64 target definitions. * Update config.h.in, not just config.h, so the latter gets regenerated correctly. * Use correct line endings. Fixes: 13759f2 ("Update project files for Visual Studio 2022.")
Now that we've fixed the x64 build, we need to define ssize_t as either a 64-bit signed int (for win64) or a 32-bit signed int (for win32).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The headers had previously been moved in a misguided attempt to prevent the build from picking up the wrong ones if TRE was already installed. Move them back, fix compiler flags to address the underlying issue, and fix preexisting issues in the Windows build.