fix: remove fullbright pixels from eyes.mdl skin - #415
Closed
mvanhorn wants to merge 1 commit into
Closed
Conversation
Owner
|
closed in preference for #416 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Parse lq1/progs/eyes.mdl (IDPO format: header, then skins as raw 8-bit palette indices) with a small throwaway Python script, identify skin bytes in the fullbright range 224-254, and remap each to the nearest non-fullbright palette entry by RGB distance against the standard Quake palette, rewriting only the skin bytes so geometry, frames, and header stay byte-identical. Apply the matching color correction to the source texture lq1/progs/src/textures/eyes.mdl.0.png so future rebuilds from the Blender source do not reintroduce fullbrights (the .blend itself needs no change since it references the PNG). Verify by re-scanning the patched mdl for indices >= 224 (expect zero) and by viewing the model in a Quake engine over a dark area.
The maintainer (lavenderdotpet) reports that eyes.mdl - the model shown for a player carrying the Ring of Shadows - contains fullbright pixels in its skin, shown in an attached screenshot of the model glowing in darkness. In the Quake palette, indices 224-254 are fullbright: pixels using them ignore lightmaps and render at full intensity, so an unintentionally quantized skin glows in dark areas. The issue is labeled bug and models, has no comments, no assignee, and no linked PRs. The fix is a bounded asset correction to one model.
Fixes #316
Visual Sample
Checklist