Skip to content

Cannot use typer in form inputs #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jnettome wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Cannot use typer in form inputs #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d971a59
Added typer ability to form inputs
jnettome Jul 11, 2013
3be5222
Added typer ability to form inputs in a better way
jnettome Jul 11, 2013
5bc6546
Resolves #13
jnettome Feb 12, 2014
673e12f
Updating to upstream master
jnettome Feb 12, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ If you just want to use the effect once, use `typeTo()`. It can be used as follo

```javascript
$('h3').typeTo("New Text");
$('input#text').typeTo("New Text");
```

This will do a one-time transition.
Expand Down
8 changes: 2 additions & 6 deletions src/jquery.typer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,12 +78,8 @@ String.prototype.rightChars = function(n){
return;
}


$e.text(
oldLeft +
text.charAt(0) +
oldRight
).data({
var method = $e[0].tagName.match(/INPUT|TEXTAREA/) ? 'val' : 'text';
$e[method](oldLeft + text.charAt(0) + oldRight).data({
oldLeft: oldLeft + text.charAt(0),
text: text.substring(1)
});
Expand Down
8 changes: 6 additions & 2 deletions test.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,15 +2,19 @@
<html>
<head>
</head>
<script src="//ajax.googleapis.com/ajax/libs/jquery/1.7.1/jquery.min.js"></script>
<script src="/src/jquery.typer.js"></script>
<script src="http://ajax.googleapis.com/ajax/libs/jquery/1.10.2/jquery.min.js"></script>
<script src="src/jquery.typer.js"></script>
<body>

<h1>Hello, World!</h1>
<h2 data-typer-targets="Hello,Hi,Hola,Hallo,Haai,Ola,Kaixo,Moni,Aloha,Bonjour,Ciao,Hej">Welcome</h2>

<h2 data-typer-targets="abcdefgfedcba,afgfa">Welcome</h2>

<input type="text" data-typer-targets="type your username here, tell me your username" />
<br/ >
<textarea data-typer-targets="write your message here"></textarea>

<script>
$(function () {
$('[data-typer-targets]').typer();
Expand Down