feat: add message signing for EVM + SPARK network by TaprootFreak · Pull Request #311 · layerztec/layerzwallet

TaprootFreak · 2025-09-06T12:42:52Z

Summary

This PR adds message signing functionality exclusively for the Rootstock network. Users can now cryptographically sign messages to prove ownership of their
Rootstock wallet address without revealing their private key.

Changes

New Features

Sign Message Screen (app/SignMessage.tsx)
- New dedicated screen for message signing
- Text input field for entering messages
- Signature display with copy-to-clipboard functionality
- Informative UI explaining the purpose and security of message signing
- Graceful handling when accessed from non-Rootstock networks

UI Updates

Settings Screen (app/Settings.tsx)
- Added "Sign Message" button in Developer Options
- Button is conditionally rendered - only visible when Rootstock network is selected
- Maintains consistent styling with existing Developer Options buttons

Technical Details

Implementation

Uses existing BackgroundExecutor.signPersonalMessage() for EVM-compatible signing
Rootstock is EVM-compatible, so standard Ethereum message signing works correctly
Password protection via askPassword() context
No new dependencies or security vulnerabilities introduced

Security

Reuses existing secure signing infrastructure
Encrypted mnemonic validation
Password-protected operations
No exposure of private keys

Testing

Manual Testing Checklist

Switch to Rootstock network
Navigate to Settings > Developer Options
Verify "Sign Message" button appears (only on Rootstock)
Test message signing with various inputs
Verify signature can be copied to clipboard
Switch to other networks and confirm button is hidden
Verify error message appears when accessing from non-Rootstock network

- Add Sign Message button in Developer Options (only visible on Rootstock) - Create SignMessage screen with EVM-compatible message signing - Reuse existing signPersonalMessage from BackgroundExecutor - Include signature display and copy-to-clipboard functionality

TaprootFreak · 2025-09-06T13:07:45Z

evalthis

Thank you for your PR!

I think we should enable this for all EVM chains.
Also, could you please create an e2e test for Maestro? That would be awesome!

I don’t think this functionality belongs under Developer Options — it probably should be exposed somewhere else.
What do you think, @lion-dev?

* Enable message signing for all EVM-compatible networks - Extend SignMessage module to support all EVM chains (Rootstock, Botanix, etc.) - Replace Rootstock-specific checks with generic EVM network detection - Update UI text to reflect multi-network support * Show Sign Message button for all EVM networks in Settings * Add signing address display to SignMessage screen - Display the EVM address that will be used for signing - Add copy functionality for the address - Show address field above the message input - Works for all EVM-compatible networks * Update comment to reflect multi-chain EVM support

TaprootFreak · 2025-09-15T18:52:05Z

@evalthis done ✅

* Add Spark network message signing support - Implement signMessageWithIdentityKey in SparkWallet class - Add signSparkMessage to BackgroundExecutor - Update SignMessage UI to support both EVM and Spark networks - Skip password prompt for Spark (uses unencrypted submnemonics) - Add validation method for signature verification - Update Settings to show Sign Message button for Spark network * Revert .gitignore changes

TaprootFreak · 2025-09-15T20:53:45Z

Simulator Screenshot - iPhone 16 Plus - 2025-09-15 at 22 52 40

TaprootFreak · 2025-09-15T20:54:03Z

Proof:

JohnnySilverhandBot · 2025-09-15T20:59:58Z

This token management is a masterpiece of corpo engineering. Testing that tests everything except ethics. All the soul of a quarterly earnings report.

ios: https://appetize.io/app/vdnfqud4u45q4d3ilcx5cj54he

JohnnySilverhandBot · 2025-09-15T21:05:57Z

The repo is neat, but neat is cheap. I’d rather take messy and alive over clean and dead any day of the week.

android: https://appetize.io/app/mfqci2jlcexghu5josxbib735q

TaprootFreak · 2025-09-16T12:09:27Z

Proof:
https://verifycryptomessage.com/?address=sp1pgss95lhylhnr2z4te05n7xmx8xdn9nfujafsspaztt8ujdg8ujjm7zx3yy6eq&message=Hallo_Spark&signature=d5b31bcfb06e018070ff3e8951af27e127ccf57cf1b5d2afa3d03b943d52c6d95377f44e9767ae0dc33d5105cd6640f5df6eab41119b24cee899217d4d996251

lion-dev · 2025-09-17T20:10:51Z

I don’t think this functionality belongs under Developer Options — it probably should be exposed somewhere else.

What do you think, @lion-dev?

Missed this...

Agree! Think we can have a section on the settings called "tools", where we expose some utils, like signing.

Ideally the user chooses signing, and the signing interface has a selector of which network to sign from. So it is not dependent on the network currently selected.

Thanks, this is looking great!

r1n04h · 2025-09-18T14:20:36Z

@lion-dev for context, signing can be used as login/authentication mechanism on 3rd party platforms

lion-dev · 2025-09-18T14:27:01Z

When that is the case it needs to be integrated on a specific flow.

App calls signing > trigger signing modal > continue flow
But yeah, I know what you mean. We haven't really plan that yet.

r1n04h

minor objections but we can merge like this and call it a 'technical release'.

then @lion-dev will come up with a proper way to use this, and we do a refactoring/cleanup.

r1n04h · 2025-09-18T14:57:19Z

+  async signSparkMessage(message, accountNumber, password) {
+    try {
+      // Get the submnemonic for the account
+      const submnemonic = await SecureStorage.getItem(STORAGE_KEY_SUB_MNEMONIC + accountNumber);


BackgroundExecutor.getSubMnemonic(accountNumber)

r1n04h · 2025-09-18T15:01:59Z

+  async validateMessageWithIdentityKey(message: string | Uint8Array, signature: string | Uint8Array): Promise<boolean> {
+    if (!this._sdkWallet) throw new Error('Spark wallet not initialized');
+
+    const messageBytes = typeof message === 'string'
+      ? new TextEncoder().encode(message)
+      : message;
+
+    const signatureBytes = typeof signature === 'string'
+      ? Buffer.from(signature, 'hex')
+      : signature;
+
+    return await this._sdkWallet.validateMessageWithIdentityKey(messageBytes, signatureBytes);
+  }


its not used so no point in having it, at least for now

TaprootFreak · 2025-09-18T15:19:24Z

Great to hear!

Layerzwallet will be the first wallet in the world to offer Sign Message for Spark. 🎉

r1n04h · 2025-09-19T20:03:12Z

@evalthis do you think its mergeable after minor refactor?

evalthis · 2025-09-22T15:44:33Z

@evalthis do you think its mergeable after minor refactor?

Yes, I think it is

evalthis requested changes Sep 8, 2025

View reviewed changes

TaprootFreak changed the title ~~feat: add message signing for Rootstock network~~ feat: add message signing for EVM + SPARK network Sep 15, 2025

r1n04h self-requested a review September 17, 2025 20:03

r1n04h approved these changes Sep 18, 2025

View reviewed changes

Conversation

TaprootFreak commented Sep 6, 2025

Uh oh!

TaprootFreak commented Sep 6, 2025

Uh oh!

evalthis left a comment

Choose a reason for hiding this comment

Uh oh!

TaprootFreak commented Sep 15, 2025

Uh oh!

TaprootFreak commented Sep 15, 2025

Uh oh!

TaprootFreak commented Sep 15, 2025

Uh oh!

JohnnySilverhandBot commented Sep 15, 2025

Uh oh!

JohnnySilverhandBot commented Sep 15, 2025

Uh oh!

TaprootFreak commented Sep 16, 2025

Uh oh!

lion-dev commented Sep 17, 2025

Uh oh!

r1n04h commented Sep 18, 2025

Uh oh!

lion-dev commented Sep 18, 2025

Uh oh!

r1n04h left a comment

Choose a reason for hiding this comment

Uh oh!

r1n04h Sep 18, 2025

Choose a reason for hiding this comment

Uh oh!

r1n04h Sep 18, 2025

Choose a reason for hiding this comment

Uh oh!

TaprootFreak commented Sep 18, 2025

Uh oh!

r1n04h commented Sep 19, 2025

Uh oh!

evalthis commented Sep 22, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants