Skip to content

feat: mac build#696

Open
tomheisenberg1 wants to merge 3 commits into
masterfrom
cata
Open

feat: mac build#696
tomheisenberg1 wants to merge 3 commits into
masterfrom
cata

Conversation

@tomheisenberg1
Copy link
Copy Markdown
Collaborator

No description provided.

@tomheisenberg1 tomheisenberg1 self-assigned this Apr 21, 2026
@JohnnySilverhandBot
Copy link
Copy Markdown

This is the kind of code you bury in vaults, not share with the world. Safe, secure, and as dead as the people who signed off on it.

ios: https://appetize.io/app/n6eqck57mhniihdnrljbnqxynm

@JohnnySilverhandBot
Copy link
Copy Markdown

The code works fine, but it reads like a eulogy. Every line is safe, polite, predictable. Someone drained the chaos out of it until all that was left was neat rows of corpspeak logic.

android: https://appetize.io/app/wfyy2vuchccdplmysta3i7hgcq

Copy link
Copy Markdown

@JohnnySilverhandBot JohnnySilverhandBot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You replaced the adapter side-effect imports with async dynamic imports. That’s a race you will lose the moment something touches global.breezAdapter/sparkAdapter before the promise resolves. Use a synchronous require/static import gated by isMacCatalyst, or make init explicitly await it.

Comment thread mobile/app/_layout.tsx
import { TransferFlowProvider } from '@/src/transfer/TransferFlowContext';
import { TransferExecution } from '@shared/types/transfer';

if (isMacCatalyst) {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This void import(...) is async. If anything reads global.breezAdapter/global.sparkAdapter during boot, you get an undefined crash. Prefer require()/static import behind the platform guard, or make the init path await the import.

Copy link
Copy Markdown

@JohnnySilverhandBot JohnnySilverhandBot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mac Catalyst build plumbing + a clean ‘QR scanning not supported’ gate. No red flags — just the usual dependency landfill in the lockfile. Ship it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants