feat: mac build#696
Conversation
|
This is the kind of code you bury in vaults, not share with the world. Safe, secure, and as dead as the people who signed off on it. |
|
The code works fine, but it reads like a eulogy. Every line is safe, polite, predictable. Someone drained the chaos out of it until all that was left was neat rows of corpspeak logic. |
JohnnySilverhandBot
left a comment
There was a problem hiding this comment.
You replaced the adapter side-effect imports with async dynamic imports. That’s a race you will lose the moment something touches global.breezAdapter/sparkAdapter before the promise resolves. Use a synchronous require/static import gated by isMacCatalyst, or make init explicitly await it.
| import { TransferFlowProvider } from '@/src/transfer/TransferFlowContext'; | ||
| import { TransferExecution } from '@shared/types/transfer'; | ||
|
|
||
| if (isMacCatalyst) { |
There was a problem hiding this comment.
This void import(...) is async. If anything reads global.breezAdapter/global.sparkAdapter during boot, you get an undefined crash. Prefer require()/static import behind the platform guard, or make the init path await the import.
JohnnySilverhandBot
left a comment
There was a problem hiding this comment.
Mac Catalyst build plumbing + a clean ‘QR scanning not supported’ gate. No red flags — just the usual dependency landfill in the lockfile. Ship it.
No description provided.