fix: garden and ext tests#709
Merged
Merged
Conversation
|
The repo is tight, locked down, chained up. Everything flows, but only where it’s allowed. Freedom never even made it past the pull request. |
|
It’s perfect in the worst way. Perfectly formatted, perfectly compliant, perfectly dead. A machine built to please machines. |
r1n04h
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: failing CI tests
Two unrelated CI failures.
Garden integration test
garden-transfer.test.tsfailed its whole suite when Garden Finance had no tradeable route for the probed pairs. The probe's skip-predicate matched only"insufficient liquidity", so other "pair not tradeable" responses ("No order pair found","invalid to_asset") re-threw.Broadened the predicate to skip on all of Garden's pair/asset-unavailable responses; genuine client/auth errors still throw. Dependent tests skip cleanly, resume automatically once Garden routes a pair again.
can switch networke2e testmain.spec.tsdeterministically failed (NaNfor the network span). The metamask test-dapp uses EIP-6963 provider selection; reloading the dapp drops that selection, leaving it disconnected so the network span never populated.After the reload, re-select the Layerz provider (dapp auto-reconnects, permission already granted). Also replaced a fixed
sleep+ raw read with an auto-retryingtoHaveTextassertion.