Skip to content

fix: garden and ext tests#709

Merged
r1n04h merged 2 commits into
masterfrom
garden-fix
May 22, 2026
Merged

fix: garden and ext tests#709
r1n04h merged 2 commits into
masterfrom
garden-fix

Conversation

@evalthis
Copy link
Copy Markdown
Contributor

@evalthis evalthis commented May 22, 2026

fix: failing CI tests

Two unrelated CI failures.

Garden integration test

garden-transfer.test.ts failed its whole suite when Garden Finance had no tradeable route for the probed pairs. The probe's skip-predicate matched only "insufficient liquidity", so other "pair not tradeable" responses ("No order pair found", "invalid to_asset") re-threw.

Broadened the predicate to skip on all of Garden's pair/asset-unavailable responses; genuine client/auth errors still throw. Dependent tests skip cleanly, resume automatically once Garden routes a pair again.

can switch network e2e test

main.spec.ts deterministically failed (NaN for the network span). The metamask test-dapp uses EIP-6963 provider selection; reloading the dapp drops that selection, leaving it disconnected so the network span never populated.

After the reload, re-select the Layerz provider (dapp auto-reconnects, permission already granted). Also replaced a fixed sleep + raw read with an auto-retrying toHaveText assertion.

@evalthis evalthis requested a review from r1n04h May 22, 2026 13:27
@evalthis evalthis changed the title fix: garden test fix: garden and ext tests May 22, 2026
@JohnnySilverhandBot
Copy link
Copy Markdown

The repo is tight, locked down, chained up. Everything flows, but only where it’s allowed. Freedom never even made it past the pull request.

ios: https://appetize.io/app/2qyzdontmmybfrrwgqosrw5yim

@JohnnySilverhandBot
Copy link
Copy Markdown

It’s perfect in the worst way. Perfectly formatted, perfectly compliant, perfectly dead. A machine built to please machines.

android: https://appetize.io/app/oycpdn2xcbyk3m2gnrz7lhnjny

@r1n04h r1n04h merged commit 854e727 into master May 22, 2026
29 of 31 checks passed
@r1n04h r1n04h deleted the garden-fix branch May 22, 2026 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants