Repository navigation
Meowio 0.2.66: Next Episode shows again on every app - #123
Merged
Merged
Conversation
IntroDB credits times (on by default since 0.2.47) sent the next-episode check down a path that never showed the card: credits that end a few seconds before the file ends counted as a short post-credits scene and returned false. Those episodes now show the card at the credits, like credits that run to the end, and outro times from another release can no longer hold the card past the user's threshold. Desktop now uses the phone's copy of these rules. On Apple TV, Next Episode takes the corner instead of Skip Credits.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why Next Episode stopped showing
Since 0.2.47 every app looks up skip times from IntroDB by default, including the credits ("outro") of each episode. That sent the next-episode check down code paths that hide the card:
Fix
PlayerNextEpisodeRules: a short guessed scene after the credits is handled like credits that run to the end (card at the credits start). The card also shows at the user's threshold at the latest, and outro times that start after this file ends (another release) are ignored.PlayerNextEpisodeRules(added toshared-sources.txt; it was byte-identical to Nuvio Desktop 0.1.38-alpha's file before this change).Nothing else about next-episode changes: preloading, backup sources, failover, still-watching and real post-credits scenes work as before.