Repository navigation
Fix macOS startup packaging and cross-platform reliability - #9
Merged
Merged
Conversation
Bumps the linux-app group in /apps/linux with 1 update: [russh](https://github.com/warp-tech/russh). Updates `russh` from 0.62.6 to 0.63.1 - [Release notes](https://github.com/warp-tech/russh/releases) - [Commits](Eugeny/russh@v0.62.6...v0.63.1) --- updated-dependencies: - dependency-name: russh dependency-version: 0.63.1 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: linux-app ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps the rust group with 1 update: [russh](https://github.com/warp-tech/russh). Updates `russh` from 0.62.6 to 0.63.1 - [Release notes](https://github.com/warp-tech/russh/releases) - [Commits](Eugeny/russh@v0.62.6...v0.63.1) --- updated-dependencies: - dependency-name: russh dependency-version: 0.63.1 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: rust ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps the actions group with 1 update: [actions/setup-java](https://github.com/actions/setup-java). Updates `actions/setup-java` from 5 to 6 - [Release notes](https://github.com/actions/setup-java/releases) - [Commits](actions/setup-java@v5...v6) --- updated-dependencies: - dependency-name: actions/setup-java dependency-version: '6' dependency-type: direct:production update-type: version-update:semver-major dependency-group: actions ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps the android group in /apps/android with 2 updates: com.android.application and [org.json:json](https://github.com/douglascrockford/JSON-java). Updates `com.android.application` from 9.3.1 to 9.3.2 Updates `org.json:json` from 20260719 to 20260814 - [Release notes](https://github.com/douglascrockford/JSON-java/releases) - [Changelog](https://github.com/stleary/JSON-java/blob/master/docs/RELEASES.md) - [Commits](stleary/JSON-java@2026071...2026081) --- updated-dependencies: - dependency-name: com.android.application dependency-version: 9.3.2 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: android - dependency-name: org.json:json dependency-version: '20260814' dependency-type: direct:production update-type: version-update:semver-major dependency-group: android ... Signed-off-by: dependabot[bot] <support@github.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fc007f0781
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
An installed macOS build could load
libsg_ffi.dylibfrom a developer checkout. Rebuilding that library could leave the installed Swift bindings incompatible with the native record layout, matching the reported startup trap inaddTarget. The app now embeds the static Rust core, and packaging rejects external core dependencies and verifies the bundle signature.This also addresses confirmed defects found while integrating dependency PRs #5, #6, #7 and #8:
CI now covers macOS packaging and the Swift/native bridge, and requires live SSH fixtures in Linux jobs. Detailed findings and limits are in docs/RELIABILITY_AUDIT.md.
How it was verified
SG_REQUIRE_FIXTURES=1 ./scripts/check.shpasses: format, Clippy, build, 285 Rust tests, lockfile and version checks. The final pairing expiry adjustment also passed targeted tests and workspace Clippy.Interactive Windows launch/installation, Linux desktop rendering, full Android interaction, iPad and physical iOS device testing remain unverified. No release has been published and the existing installed macOS app has not been replaced.
The automated review finding is addressed: Windows rejects an unreadable inventory before saving credentials or adopting a live target, with regression coverage for preserved secrets and recovery. CI follow-ups select Xcode 16.4 for Swift 6 and make the pairing mock consume its request before closing, avoiding a Windows socket reset.
Invariants