Skip to content

fix: deduplicate nav bars and centralize layout - #35

Merged
lbowsher merged 1 commit into
mainfrom
lb/ui-dedup-cleanup
Mar 22, 2026
Merged

lbowsher merged 1 commit into
mainfrom
lb/ui-dedup-cleanup

Conversation

@lbowsher

@lbowsher lbowsher commented Mar 22, 2026

Copy link
Copy Markdown
Owner

Summary

  • Remove duplicate navigation from team page (had its own ThemeToggle + AuthButtonServer nav bar) — replaced with a breadcrumb (League Name / Team Name)
  • Remove duplicate "Home" header from new-league page (global NavBar handles this)
  • Centralize min-h-screen bg-background on <body> in layout.tsx — removed from 10 individual pages/loading/error files
  • Update loading skeletons (league, draft) to match current page structure without fake nav bar placeholders
  • Replace raw HTML input/button in search-component with shadcn Input/Button + Enter key support
  • Fix getSession()getUser() in one-tap-component.tsx (auth best practice)
  • Replace all text-liquid-lava with semantic tokens (text-primary, text-accent, text-destructive)

Test plan

  • Verify team page renders correctly with breadcrumb navigation (no duplicate nav bar)
  • Verify new-league page no longer shows a "Home" header bar
  • Verify background color is consistent across all pages (dark mode + all themes)
  • Verify loading skeletons display correctly for league and draft pages
  • Verify player search works with Enter key on team page
  • Verify Google One Tap login still works on login page
  • Test all 7 themes — accent colors should appear correctly on league standings, team links, checkboxes

🤖 Generated with Claude Code

…stencies

- Remove duplicate nav (ThemeToggle + AuthButtonServer) from team page, replace with breadcrumb
- Remove duplicate "Home" header from new-league page
- Move min-h-screen bg-background to body in layout.tsx, remove from 10 pages
- Update loading skeletons to match current page structure (no fake nav placeholders)
- Replace raw input/button in search-component with shadcn components + Enter key support
- Fix getSession() → getUser() in one-tap-component.tsx
- Replace all text-liquid-lava with semantic tokens (text-primary, text-accent, etc.)

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
@vercel

vercel Bot commented Mar 22, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
fanteasy Ready Ready Preview, Comment Mar 22, 2026 6:09pm

@lbowsher
lbowsher merged commit 9afbcba into main Mar 22, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant